-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #2, NewProjectPanel persistent state #15
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks great, thanks! One small thing - could you also persist the state of show/hide advanced options?
I'm confused. It should already persist the state of show/hide advanced options. If you open the panel and select |
Ah - it looks like the bug I've actually found is that something seems to go wrong if you change CMake or Python versions to anything other than the default. If I click Show Advanced Options, set CMake Version to Select Version, then go to a different tab and come back, the Advanced Options are hidden again and none of the CMake Version radio buttons are selected Ninja works fine, it's just CMake and Python that break it (I think) |
It looks like it's because I don't have a system CMake install, so it crashes at |
@will-v-pi You're right there where some null pointer exceptions because of the platform dependent DOM generation. Should be fixed now. Thanks for testing. |
Signed-off-by: paulober <44974737+paulober@users.noreply.github.com>
64d10c6
to
7dc96a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good now, and works on my Windows and RPiOS - thanks!
Implemented persistent state for all properties in the NewProjectPanel webview except the file inputs for ninja, cmake and python executables.