Add an entry point when signing Arm images #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kilograham
reviewed
Nov 1, 2024
kilograham
reviewed
Nov 19, 2024
main.cpp
Outdated
| std::shared_ptr<entry_point_item> entry_point = new_block.get_item<entry_point_item>(); | ||
| if (entry_point == nullptr) { | ||
| std::shared_ptr<vector_table_item> vtor = new_block.get_item<vector_table_item>(); | ||
| uint32_t vtor_loc = elf->header().entry < SRAM_START ? 0x10000000 : 0x20000000; |
There was a problem hiding this comment.
do we need to check for XIP_SRAM-only binaries here? I forget if they can be signed (i believe so)
There was a problem hiding this comment.
I've added support for this - although I'm not sure if we support XIP_SRAM binaries without a vector_table_item?
lurch
reviewed
Nov 19, 2024
| new_block.items.push_back(entry_point); | ||
| } | ||
| } | ||
|
|
||
| hash_andor_sign( |
Reads the entry point and stack pointer from the vector table Assumes vector table is at 0x10000000 unless a vector_table metadata item is present
kilograham
approved these changes
Nov 20, 2024
kilograham
reviewed
Nov 20, 2024
kilograham
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reads the entry point and stack pointer from the vector table, and adds them to the image_def as a new entry_point item. This is only done for signing Arm executable images.
This assumes that the vector table is at 0x10000000 unless a vector_table metadata item is present, which the SDK adds for no_flash binaries, so it should work with all SDK binaries.