feat: allow usage in Ruby 3 projects #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raszi
reviewed
Jan 27, 2021
| @@ -23,7 +23,7 @@ Gem::Specification.new do |spec| | |||
| spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) } | |||
| spec.require_paths = ['lib'] | |||
|
|
|||
| spec.required_ruby_version = '~> 2.5' | |||
| spec.required_ruby_version = '> 2.5' | |||
There was a problem hiding this comment.
This is a bit overly optimistic, but I'll leave it like that for now.
raszi
approved these changes
Jan 27, 2021
raszi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using this in a project that is being upgraded to Ruby 3 and the
required_ruby_versionis restricting this to only Ruby versions greater than 2.5 but less than 3.0.Additionally, when testing this update, it seems that
FileUtilswas not being required and needs to be, so I added a require. It's not clear why this became a problem, and if there is another solution you'd prefer to this, let me know.