Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support calling remove callback multiple times #300

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nwalters512
Copy link

While refactoring some code, I ended up accidentally calling the remove callback multiple times. It took me way too long to figure out why it seemed like my process was hanging: because the callback passed to the remove callback isn't invoked when the remove callback is called multiple times.

I acknowledge that one shouldn't end up calling the remove callback multiple times in normal usage, but it's a big violation of expectations for my own callback to never be called in that situation. I'm hoping you'll accept this patch. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant