Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic properties #1065

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

mmaennche
Copy link

PHP Compatability for Dynamic Properties
React\Socket\Connection::$decor
Ratchet\Server\IoConnection::$resourceId
Ratchet\Server\IoConnection::$remoteAddress
Ratchet\Server\IoConnection::$httpHeadersReceived
Ratchet\Server\IoConnection::$httpBuffer
Ratchet\Server\IoConnection::$httpRequest
Ratchet\Server\IoConnection::$WebSocket

React\Socket\Connection::$decor
Ratchet\Server\IoConnection::$resourceId
Ratchet\Server\IoConnection::$remoteAddress
Ratchet\Server\IoConnection::$httpHeadersReceived
Ratchet\Server\IoConnection::$httpBuffer
Ratchet\Server\IoConnection::$httpRequest
Ratchet\Server\IoConnection::$WebSocket
React\Socket\Connection::$decor
Ratchet\Server\IoConnection::$resourceId
Ratchet\Server\IoConnection::$remoteAddress
Ratchet\Server\IoConnection::$httpHeadersReceived
Ratchet\Server\IoConnection::$httpBuffer
Ratchet\Server\IoConnection::$httpRequest
Ratchet\Server\IoConnection::$WebSocket
React\Socket\Connection::$decor
React\Socket\Connection::$decor
@Tofandel
Copy link

Maybe a proper fix should be both #1060 and this, because it was previously encouraged to add properties to the connection in onOpen which would trigger the warning as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants