Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to PHPUnit 7 #700

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Upgrade to PHPUnit 7 #700

wants to merge 2 commits into from

Conversation

mbonneau
Copy link
Member

This upgrades to PHPUnit 7.

There are a couple tests for sessions that are marked incomplete because of an ini_set issue.

This also drops travis checking for everything but 7.1 and higher as 7.0 and lower are not supported by PHPUnit 7.

It may be good to bump the project to 7.1 and higher anyway as PHP 7.0 is approaching the end of security support in 17 days.

Includes #683 .

Copy link

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fact that this PR adding PHP 7 support is #700 pleases me 👍

@frank9999
Copy link
Contributor

PHPUnit 7 is EOL, @cboden are you considering upgrading PHPUnit to version 9, and drop support for older PHP versions?

@cboden
Copy link
Member

cboden commented Dec 6, 2021

v0.5 (next version) to keep BC, v0.6 to drop older PHP versions. See #850

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants