Add sorting classes to table headers #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ratiw any objections to this PR now that it's from |
|
@jwkicklighter Sorry for the delay as I'm fully occupied by the work and still haven't gone through everything in the PR. But I don't think there is any objection since I'm now understand why you need this and I see it as an enhancement that would not affect anything in the previous release. I'll try to find time to merge it. Thank you so much. :) |
|
No problem @ratiw, just wanted to make sure I could jump on changes if there was anything obvious! :) |
ratiw
added a commit
that referenced
this pull request
Dec 23, 2017
|
Documentation for these properties is not yet defined in the documentation. Todo? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a class to a th element whenever that column is sorted, configurable from the css prop. Also adds a showSortIcons prop to disable inserting the icon elements if desired. This seems like a pretty low risk solution to provide some extra flexibility for other use cases.
Likely solves #48
Fixing #262 by actually using
develop