bundle.bbclass: fix variable expansion of RAUC_META_* varflags #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Variables assigned to `RAUC_META_<section>[varflag]` are not expanded anymore. This is caused by `getVarFlags` not expanding variables by default, revert to using `getVarFlag` which does expand variables by default. Fixes: rauc#335 Fixes: ffba61f ("bundle.bbclass: simplify varflag usage") Signed-off-by: Ludovic Jozeau <ludovic.jozeau@scle.fr> Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
jluebbe
force-pushed
the
fix/rauc_meta_sections
branch
from
26e69ab
to
792b1cc
Compare
|
I've force-pushed to align the commit message with our conventions. |
jluebbe
approved these changes
Jul 25, 2024
|
Alright, no problem, thanks |
|
Backported to scarthgap. |
|
Thanks for debugging and fixing this! |
|
sure no problem :) |
|
backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
variables assigned to
RAUC_META_<section>[varflag]are not expanded anymore.This is caused by
getVarFlagsnot expanding variables by default, revert to usinggetVarFlagwhich does expand variables by default.fix #335
partially revert changes introduced in ffba61f