-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROS catkinization #2
base: master
Are you sure you want to change the base?
Conversation
Very good. all my friends always have to do that when download orbslam. |
Hello! I am attempting to build your branch, but I feel like some steps are missing. I appended the "Example/ROS" to the ROS_PACKAGE_PATH. I had 3 extra modifications to make it work:
Then I can run catkin_make on the "Example/ROS" directory, and everything seems to be working correctly now. Am I missing something? |
Thanks for your work! @plnegre |
Hello @buqing2009, make sure that your orb_slam package is into your ROS_PACKAGE_PATH variable (echo ${ROS_PACKAGE_PATH}) Hope it helps! |
I wasn't able to build it either. I cloned the repository into catkin_ws/src, then ran catkin_make in the catkin_ws, but errors showed up: In file included from /home/mma2739/catkin_ws/src/ORB_SLAM2/Examples/ROS/orb_slam2/../../../Thirdparty/g2o/g2o/types/../core/optimizable_graph.h:37:0, I did check (echo ${ROS_PACKAGE_PATH}), which gives as an output: Am I missing something? |
Hello @marcelinomalmeidan, Please, refer to the README file for instructions on how to compile it in ROS. |
@plnegre, isn't the whole point of catkinizing to avoid using build?
|
No. The ORB_SLAM2 is still had independent dependencies that must be built before catkin_make runs. |
Alright, thanks! I'll try it later! |
Where do I need to add the orb_slam folder, should I add to catkin_ws? |
Hello @lucasmedino Please, refer to the README file for instructions on how to compile it in ROS |
Compile fixes.
removing static variables to be thread-safe
Based on the pull request by plnegre: raulmur#2
@plnegre Thank you for your sharing! I have a problem here: I have tried Hope for your help! Thx |
Hello @raulmur,
The ROS examples you provide, are build using a very old tool (rosbuild), which is not longer supported.
The new build tool for ROS is catkin. I catkinized the package so everybody can use it in hydro, indigo and further versions.