Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ffmpeg availability check in Mix tasks #154

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 11 additions & 18 deletions lib/mix/tasks/check.ex
Original file line number Diff line number Diff line change
@@ -1,14 +1,11 @@
defmodule Rauversion.Checks.CheckFFMPEG do
def run() do
{_, status} = System.cmd("which", ["ffmpeg"])
case System.find_executable("ffmpeg") do
nil ->
{:error, "'ffmpeg' command not found on the system. Please install it to proceed."}

case status do
0 ->
true

err ->
IO.inspect(err, label: "ffmpeg error")
raise "ffmpeg command not found"
_path ->
{:ok, "'ffmpeg' command is available on the system."}
end
end
end
Expand All @@ -18,20 +15,16 @@ defmodule Mix.Tasks.Check do

alias Rauversion.Checks.CheckFFMPEG

defp is_ok(true) do
IO.inspect("All checks passed")
end

defp is_ok(_) do
raise "Some dependencies are missing or wrongly configured."
defp is_ok({:ok, message}) do
Mix.shell().info(message)
end

defp check() do
CheckFFMPEG.run()
defp is_ok({:error, reason}) do
Mix.raise(reason)
end

@shortdoc "Check if deps versions are met."
def run(_id) do
is_ok(check())
def run(_args) do
is_ok(CheckFFMPEG.run())
end
end