Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(frontend): Separate contents of pages into separate components #594

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ravenclaw900
Copy link
Owner

Part 3 of 3 to cleanup frontend

This should make it much easier to maintain the frontend and helps with DRY. Especially in the file browser page, because that's a mess right now.

@ravenclaw900 ravenclaw900 self-assigned this Jul 11, 2023
@ravenclaw900 ravenclaw900 changed the title refactor(frontend): Separate pages into separate components refactor(frontend): Separate contents of pages into separate components Jul 11, 2023
@ravenclaw900
Copy link
Owner Author

The large increase in binary size seems to be the fact that the toml crate now uses toml_edit as its parser. The concerns about binary size were mentioned in toml-rs/toml#340, however it seems like nothing has been done about it yet.

…ning the function outside of the component

Also slightly changes the folder structure for components use by App and shared components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant