Revert "add readline(::AbstractCmd) (JuliaLang#34927)" (JuliaLang#34958)

This reverts commit 570f6d9.
ravibitsgoa · Apr 6, 2020 · 026a87b · 026a87b
1 parent cbba6ae
commit 026a87b
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 10 deletions.
diff --git a/base/process.jl b/base/process.jl
@@ -320,8 +320,6 @@ function eachline(cmd::AbstractCmd; keep::Bool=false)
     return EachLine(out, keep=keep, ondone=ondone)::EachLine
 end
 
-readline(cmd::AbstractCmd; keep::Bool=false) = first(eachline(cmd, keep=keep))
-
 """
     open(command, mode::AbstractString, stdio=devnull)
 

diff --git a/test/spawn.jl b/test/spawn.jl
@@ -670,14 +670,6 @@ end
 @test repr(Base.CmdRedirect(``, devnull, 1, true)) == "pipeline(``, stdout<Base.DevNull())"
 @test repr(Base.CmdRedirect(``, devnull, 11, true)) == "pipeline(``, 11<Base.DevNull())"
 
-@testset "readline" begin
-    @test readline(`$(printfcmd) '\n'`) == ""
-    @test readline(`$(printfcmd) 'foo\n'`) == "foo"
-    @test readline(`$(printfcmd) 'foo\nbar\n'`) == "foo"
-    @test readline(yescmd) == "y"
-    @test readline(pipeline(`$(printfcmd) 'foo\nbar\n'`, sortcmd)) == "bar"
-    @test_throws ArgumentError("collection must be non-empty") readline(`$(printfcmd) ''`)
-end
 
 # clean up busybox download
 if Sys.iswindows()