Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a custom data parse for remote data. #50

Merged
merged 2 commits into from
Oct 26, 2017

Conversation

integral-llc
Copy link
Contributor

No description provided.

@ravibpatel
Copy link
Owner

@integral-llc Can you post the URL of JSON file you used. So I can test it out.

@integral-llc
Copy link
Contributor Author

Something like this, https://app.gopapr.com/version see the payload. Url is to be replaced with a correct one.

@ravibpatel
Copy link
Owner

ravibpatel commented Oct 25, 2017

Why use Interface when we can use already available UpdateInfoArgs class? Using interface will add overhead for other devs. They need to create a class like JsonUpdateInfo to use this feature. I want to keep it simple if its possible.

* Fixed issue with null check.
* Added example of JSON parsing.
@ravibpatel ravibpatel merged commit 23ace4e into ravibpatel:master Oct 26, 2017
@integral-llc integral-llc deleted the update-info-custom-parsing branch October 26, 2017 17:09
JavierCanon pushed a commit to JavierCanon/AutoUpdater.NET that referenced this pull request Aug 5, 2018
ansonliam pushed a commit to ansonliam/AutoUpdater.NET that referenced this pull request Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants