Fall-back for wrongly formatted content-disposition headers #610
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some servers provided wrongly formatted content-disposition headers, e.g. Artifactory writes as Content-Disposition
attachment; filename="setup.exe"; filename*=UTF-8''"setup.exe"
where the quotations (") within the filename* parameter yield a C# Format-Exception and cause a error message to be displayed. Since AutoUpdater.NET does not rely on the Content-Disposition Header but can fall-back to the filename from the download URL, this PR catches such errors and ignores such faulty Content-Disposition headers.