Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempting to add formspree_form_path site variable #11

Merged
merged 1 commit into from
Nov 1, 2020

Conversation

morozgrafix
Copy link
Contributor

possible fix for #10

Should maintain backwards compatibility if formspree_form_path is not set in older _config.yml installations.

Tested only locally, may need additional testing.

This is an enhancement or feature.

Summary

Formspree is phasing out legacy forms (email URLs).

<form action="https://formspree.io/your@email.com" method="POST"> is considered to be a legacy URL. Newly created forms utilize form_id URL path like <form action="https://formspree.io/f/a_form_id" method="POST">

Context

Formspree articles related to the upcoming change: https://help.formspree.io/hc/en-us/articles/360017735154-How-to-prevent-spam and https://help.formspree.io/hc/en-us/articles/360056076314

Solution may work for raviriley#10

Should maintain backwards compatibility if `formspree_form_path` is not set in older `_config.yml` installations.

Tested only locally, may need additional testing.

comment out formspree_form_path for backwards compatibility
@morozgrafix morozgrafix changed the title Attempting to add formspree_path site variable Attempting to add formspree_form_path site variable Nov 1, 2020
Copy link
Owner

@raviriley raviriley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested on my end and works as intended.

@raviriley raviriley merged commit e044416 into raviriley:master Nov 1, 2020
@WebAdministratorArsova
Copy link

How can I fix this? I dont found the line "

" in my code and I'm trying to fix this issue to make it work for my website

@WebAdministratorArsova
Copy link

How can I fix this? I dont found the line "

" in my code and I'm trying to fix this issue to make it work for my website

<form action="https://formspree.io/your@email.com" method="POST">``

@WebAdministratorArsova
Copy link

I think there are some files that are hide with this theme or I dont figure out how to edit it, for example this line that I post before I dont found what file contains this

@WebAdministratorArsova
Copy link

@raviriley hey dude, could you please help me? I want to get a better understanding of this theme, I want to fix this issue with the forms and I want to be able to edit the page for example I just comment some sections to try to remove it like the "team members" but I have still that space in "blank" in the web site

@raviriley
Copy link
Owner

@WebAdministratorArsova could you open an issue with the problem you're encountering?

dkbnz pushed a commit to dkbnz/agency-jekyll-theme that referenced this pull request Jul 12, 2022
Adapts contact form to new [Formspree Form ID update](https://help.formspree.io/hc/en-us/articles/360017735154-How-to-prevent-spam) with formspree_form_path site variable. Legacy forms (using email) are being phased out by Formspree. Click [here](https://help.formspree.io/hc/en-us/articles/360056076314) for more info.
@WebAdministratorArsova
Copy link

@WebAdministratorArsova could you open an issue with the problem you're encountering?

For sure but its the same topic as this conversation, my "contact" form is not working and I read in this post that I have to modify it to set my form id not just my email in the config.yml so then.. I dont know where I should modify this in the config we have a line to write down your email and it say that will use it for the contact form but is not working, you could see my repository here https://github.com/WebAdministratorArsova/WebAdministratorArsova.github.io

I just comment the part of the contact form while I could fix it

@raviriley
Copy link
Owner

raviriley commented Jul 12, 2022

@WebAdministratorArsova add the following to your _config.yml:

formspree_form_path: "f/a_form_id"

Notice this at the bottom of the config file:

# Uncomment following line to use Formspree form ID based URL instead of email based URL
# Details: https://help.formspree.io/hc/en-us/articles/360017735154-How-to-prevent-spam
# formspree_form_path: "f/a_form_id"

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants