Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use node v20 instead of v16 #124

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Conversation

ravgeetdhillon
Copy link
Member

Related Issues:

@ravgeetdhillon ravgeetdhillon merged commit cdff362 into master Jan 30, 2024
1 check passed
@ravsam-bot ravsam-bot bot deleted the dev/ravgeet/issues-123 branch January 30, 2024 17:42
@ravgeetdhillon ravgeetdhillon mentioned this pull request Jan 30, 2024
@fede843
Copy link

fede843 commented Feb 7, 2024

Hi, I am still getting

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: ravsamhq/notify-slack-action@2.4.0. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Am I using it wrong?

@alexatkoverse
Copy link

ravgeetdhillon Please understand that your action is using node 16 and using it in GH prouces now this warning

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: ravsamhq/notify-slack-action@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

It is kind of annoying to see it every time.

In order to repro it, please run your action in GH to see it yourself.

That merge didn't fix the action run itself -- looks like only your own test runs.

There are already mentioned in the latest open PR what will fix it. Please merge it when you get a chance.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants