fix(rax-app): debug() run as needed and optimizing stringify (#1029)

* fix(rax-app): debug() run as needed and replace JSON.stringify with util.inspect for circular * docs(rax-app): change version, readme and comment
raxjs · Aug 16, 2023 · 6c86dba · 6c86dba
1 parent 0e750d3
commit 6c86dba
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 11 deletions.
diff --git a/packages/plugin-rax-app/CHANGELOG.md b/packages/plugin-rax-app/CHANGELOG.md
@@ -1,5 +1,8 @@
 # Changelog
 
+## 7.0.14
+- Fix: change `debug(JSON.stringify(configs, ...))` to run only in debug mode, and modify the implement of `stringify` that will cause Node16 Crash when `configs` has many circular reference in `logWebpackConfig.js`
+
 ## 7.0.12
 
 - Feat: breaking change for `rax-webpack-config` to update `postcss-loader`

diff --git a/packages/plugin-rax-app/package.json b/packages/plugin-rax-app/package.json
@@ -1,6 +1,6 @@
 {
   "name": "build-plugin-rax-app",
-  "version": "7.0.13",
+  "version": "7.0.14",
   "description": "The basic webpack configuration for rax project",
   "author": "Rax Team",
   "main": "lib/index.js",

diff --git a/packages/plugin-rax-app/src/utils/logWebpackConfig.ts b/packages/plugin-rax-app/src/utils/logWebpackConfig.ts
@@ -1,19 +1,15 @@
 import debugCore from 'debug';
+import { inspect } from 'util';
 
 const debug = debugCore('rax-app');
 
 export default (configs) => {
   try {
-    const tmp = [];
-    debug(JSON.stringify(configs, (key, val) => {
-      if (val != null && typeof val === 'object') {
-        if (tmp.indexOf(val) >= 0) {
-          return;
-        }
-        tmp.push(val);
-      }
-      return val;
-    }, 2));
+    // Only executed when the debug mode is turned on
+    if (debug.enabled) {
+      // Print webpack configs for easy debugging
+      debug(inspect(configs, { depth: 10, colors: true }));
+    }
   } catch (error) {
     // ignore error
   }