Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: command register for debug ssr app #38

Merged
merged 3 commits into from
Oct 29, 2019
Merged

refactor: command register for debug ssr app #38

merged 3 commits into from
Oct 29, 2019

Conversation

chenjun1011
Copy link
Contributor

调整 commander 注册方式，以支持 ssr 应用的 debug

原有 Git-style executable (sub)commands 的注册方式会导致端口占用， 见 tj/commander.js#533

image

调整前

image

调整后

可正常 debug

image

wssgcg1213
wssgcg1213 approved these changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@wssgcg1213 wssgcg1213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

@wssgcg1213
Copy link
Contributor

冲突解决一下

@Orange-C Orange-C changed the base branch from master to release/scripts-1030 October 29, 2019 12:46
@Orange-C Orange-C merged commit 66bdef3 into release/scripts-1030 Oct 29, 2019
@Orange-C Orange-C deleted the feat-ssr-debug branch October 29, 2019 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wssgcg1213 wssgcg1213 wssgcg1213 approved these changes

@Orange-C Orange-C Orange-C approved these changes

@yundongbot yundongbot Awaiting requested review from yundongbot

@yuanyan yuanyan Awaiting requested review from yuanyan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chenjun1011 @wssgcg1213 @Orange-C