Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rax-app support css modules #488

Merged
merged 7 commits into from
Nov 18, 2020
Merged

feat: rax-app support css modules #488

merged 7 commits into from
Nov 18, 2020

Conversation

imsobear
Copy link
Contributor

@imsobear imsobear commented Nov 16, 2020

背景

脚手架默认 inlineStyle 改为 false 之后,用 css 冲突概率很大,因此希望统一成 CSS Module,但是如果开发者把 inlineStyle 改为 true 就报错了,因此 babel-plugin-transform-jsx-stylesheet@1.0 支持了 inlineStyle+CSS Module #424

影响

- import './index.css';
+ import styles from './index.module.css';

- <div className="logo" />
+ <div className={styles.logo} />  

后续 Action

  • rax-materials 脚手架默认改为 CSS Module 写法

@imsobear imsobear changed the base branch from master to release-next November 17, 2020 03:15
@imsobear imsobear changed the title feat: css modules feat: rax-app support css modules Nov 17, 2020
@codecov-io
Copy link

codecov-io commented Nov 17, 2020

Codecov Report

Merging #488 (d0dffea) into release-next (7eb6d85) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           release-next     #488   +/-   ##
=============================================
  Coverage         90.20%   90.20%           
=============================================
  Files                20       20           
  Lines               725      725           
  Branches            193      193           
=============================================
  Hits                654      654           
  Misses               69       69           
  Partials              2        2           

@imsobear imsobear mentioned this pull request Nov 17, 2020
7 tasks

Runs the app in development mode.

Open [http://localhost:9999](http://localhost:9999) to view it in the browser.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README 描述不太对

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@SoloJiang SoloJiang merged commit d43ea26 into release-next Nov 18, 2020
@SoloJiang SoloJiang deleted the feat-css-modules branch November 18, 2020 09:38
SoloJiang added a commit that referenced this pull request Nov 23, 2020
* fix(miniapp): duplicated taskname when both ali and wechat are compiled

* fix: compact react plugin targets is undefined (#490)

* feat: rax-app support css modules (#488)

* chore: CSS Modules

* chore: style example

* build(example): modify jsx compilerOptions to preserve in tsconfig

* chore: optimize example

* chore: upgrade dep version

* chore: remove branch_name

* chore: readme

Co-authored-by: 逆葵 <xianyong.yxy@alibaba-inc.com>

* fix: custom output dir (#494)

* fix: custom output dir

* fix: ci error

* fix: ci error

* fix: ci yml

* chore: remove useless code

* feat: add enable assets

* fix: compatible with build-mpa-config (#499)

* chore: bump version (#497)

* chore: bump version

* chore: update version

* chore: update version

* chore: update version

* fix: dep check error

* chore: add changelog

* chore: update version

* chore: update version

Co-authored-by: 逆葵 <xianyong.yxy@alibaba-inc.com>
Co-authored-by: NK <yxy0919@foxmail.com>
Co-authored-by: 大果 <sobear.me@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants