-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rax-app support css modules #488
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release-next #488 +/- ##
=============================================
Coverage 90.20% 90.20%
=============================================
Files 20 20
Lines 725 725
Branches 193 193
=============================================
Hits 654 654
Misses 69 69
Partials 2 2 |
SoloJiang
approved these changes
Nov 18, 2020
examples/with-rax-style/README.md
Outdated
|
||
Runs the app in development mode. | ||
|
||
Open [http://localhost:9999](http://localhost:9999) to view it in the browser. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
README 描述不太对
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
SoloJiang
added a commit
that referenced
this pull request
Nov 23, 2020
* fix(miniapp): duplicated taskname when both ali and wechat are compiled * fix: compact react plugin targets is undefined (#490) * feat: rax-app support css modules (#488) * chore: CSS Modules * chore: style example * build(example): modify jsx compilerOptions to preserve in tsconfig * chore: optimize example * chore: upgrade dep version * chore: remove branch_name * chore: readme Co-authored-by: 逆葵 <xianyong.yxy@alibaba-inc.com> * fix: custom output dir (#494) * fix: custom output dir * fix: ci error * fix: ci error * fix: ci yml * chore: remove useless code * feat: add enable assets * fix: compatible with build-mpa-config (#499) * chore: bump version (#497) * chore: bump version * chore: update version * chore: update version * chore: update version * fix: dep check error * chore: add changelog * chore: update version * chore: update version Co-authored-by: 逆葵 <xianyong.yxy@alibaba-inc.com> Co-authored-by: NK <yxy0919@foxmail.com> Co-authored-by: 大果 <sobear.me@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
背景
脚手架默认 inlineStyle 改为 false 之后,用 css 冲突概率很大,因此希望统一成 CSS Module,但是如果开发者把 inlineStyle 改为 true 就报错了,因此 babel-plugin-transform-jsx-stylesheet@1.0 支持了 inlineStyle+CSS Module #424
影响
后续 Action