feat: pha 源码链路 #507
Merged
feat: pha 源码链路 #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SoloJiang
reviewed
Nov 25, 2020
examples/with-rax-pha/README.md
Outdated
| @@ -0,0 +1,3 @@ | |||
| # with rax mpa | |||
examples/with-rax-pha/README.md
Outdated
| @@ -0,0 +1,3 @@ | |||
| # with rax mpa | |||
|
|
|||
| https://github.com/ice-lab/icejs/tree/master/examples | |||
examples/with-rax-pha/build.json
Outdated
| { | ||
| "targets": ["web"], | ||
| "web": { | ||
| "mpa": true, |
examples/with-rax-pha/package.json
Outdated
| @@ -0,0 +1,22 @@ | |||
| { | |||
| "name": "with-rax", | |||
packages/plugin-rax-pha/src/index.js
Outdated
| }); | ||
|
|
||
| onGetWebpackConfig(target, (config) => { | ||
| function setEntry(type) { |
packages/plugin-rax-pha/src/index.js
Outdated
| .add(appWorkerPath) | ||
| .end() | ||
| .output | ||
| .path(path.resolve(rootDir, outputDir, 'web')) |
There was a problem hiding this comment.
outputDir 在 onGetWebpckConfig 的回调里拿吧，这里拿的是最新的
packages/plugin-rax-pha/src/index.js
Outdated
| .end() | ||
| .devServer | ||
| .inline(false) | ||
| .hot(false); |
packages/plugin-rax-pha/src/index.js
Outdated
| .end() | ||
| .output | ||
| .path(path.resolve(rootDir, outputDir, 'web')) | ||
| .filename('[name].js') |
| if (config.plugins.has('CopyWebpackPlugin')) { | ||
| config.plugin('CopyWebpackPlugin').tap(() => { | ||
| return [ | ||
| [], |
There was a problem hiding this comment.
这里应该只用去除 public 那个吧，如果用户有别的需要复制的，会挂掉
There was a problem hiding this comment.
都不需要 copy 吧，copy 也是在 web target，不是 pha target
packages/plugin-rax-pha/src/index.js
Outdated
| }); | ||
| // app.json to manifest.json | ||
| config.plugin('ManifestJSONPlugin') | ||
| .use(class ManifestJSONPlugin { |
SoloJiang
previously approved these changes
Nov 26, 2020
ClarkXia
reviewed
Nov 26, 2020
| const { userConfig, rootDir } = context; | ||
| const { outputDir = 'build' } = userConfig; | ||
|
|
||
| const appWorkerPath = path.resolve(rootDir, 'src/pha-worker' + (type === 'ts' ? '.ts' : '.js')); |
There was a problem hiding this comment.
path.resolve 如果不存在的情况下是不是会异常
There was a problem hiding this comment.
path 只是字符串拼接, 不存在 io 操作; fs 里面有可能 IOException
There was a problem hiding this comment.
@ClarkXia 下面有 pathExist 的判断
packages/plugin-rax-pha/src/index.js
Outdated
|
|
||
| onGetWebpackConfig(target, (config) => { | ||
| setEntry(context, config, 'ts'); | ||
| setEntry(context, config, 'js'); |
There was a problem hiding this comment.
两次 setEntry 理解上有点奇怪，可以内部消化掉 ts/js 文件逻辑
ClarkXia
approved these changes
Nov 27, 2020
SoloJiang
approved these changes
Nov 30, 2020
Merged
SoloJiang
added a commit
that referenced
this pull request
Dec 3, 2020
* chore: bump version * feat: pha 源码链路 (#507) * chore: code lint * chore: add address npm * chore: code refactor * chore: fix test * chore: version back * chore: setEntry code optimization Co-authored-by: boiawang <zhengwang.z@alibaba-inc.com> Co-authored-by: 狒狒神 <fushen.jzw@alibaba-inc.com> * feat: support mock (#506) * fix: chunk load (#505) * fix: chunk load * chore: add comment * feat: add dev info to temp file (#511) * feat: support specified targets (#508) * feat: support specified targets * feat: add cancel task * fix: entry * chore: rename cli targets * feat: add compiled time (#515) * chore: bump version (#514) * chore: bump version * chore: bump beta version * chore: bump version Co-authored-by: 岭伊 <zhengwang2314@gmail.com> Co-authored-by: boiawang <zhengwang.z@alibaba-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#444
build.json 配置
{ "web": { "pha": true } }