Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: pha cross slide #601

Merged
merged 10 commits into from
Feb 19, 2021
Merged

feat: pha cross slide #601

merged 10 commits into from
Feb 19, 2021

Conversation

SoloJiang
Copy link
Contributor

@SoloJiang SoloJiang commented Feb 1, 2021 •
edited
Loading

@SoloJiang SoloJiang changed the base branch from master to release-next February 18, 2021 06:20
chenjun1011
chenjun1011 reviewed Feb 18, 2021
View reviewed changes
packages/plugin-rax-store/src/generator.ts Outdated
@@ -54,6 +54,7 @@ export default class Generator {
const srcPath = path.join(this.rootDir, this.srcDir);

pageEntries.forEach((pageEntry) => {
console.log('pageEntry=====>', pageEntry);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

chenjun1011
chenjun1011 reviewed Feb 18, 2021
View reviewed changes
packages/plugin-rax-store/src/utils/modifyRoutes.ts Outdated
return route;
}
if (route.tabHeader) {
route.tabHeader = modifyRoute(route.tabHeader, tempPath, filename, srcPath, projectType, mpa);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pageHeader

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@SoloJiang SoloJiang merged commit 4e97f78 into release-next Feb 19, 2021
@SoloJiang SoloJiang deleted the feat/pha-frames branch February 19, 2021 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wssgcg1213 wssgcg1213 wssgcg1213 left review comments

@chenjun1011 chenjun1011 chenjun1011 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SoloJiang @chenjun1011 @wssgcg1213