[Refactor]: Document #618
Merged
[Refactor]: Document #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: ssr document mode error * chore: add test case * fix: midway plugin ssr * feat: support getInitialData * fix: page component getInitial props in spa * chore: add window fallback * chore: optimize code
SoloJiang
commented
Feb 25, 2021
| @@ -79,7 +79,9 @@ module.exports = function (api) { | |||
| // Remove outputDir when start devServer | |||
| const { outputDir = 'build' } = userConfig; | |||
| configs.forEach((config) => { | |||
| fs.emptyDirSync(path.resolve(rootDir, outputDir, config.name)); | |||
| if (config.name) { | |||
SoloJiang
commented
Feb 25, 2021
| export default class LocalBuilderPlugin { | ||
| apply(compiler) { | ||
| compiler.hooks.shouldEmit.tap(PLUGIN_NAME, (compilation) => { | ||
| emit(compilation.assets); |
SoloJiang
commented
Feb 25, 2021
| const { appConfig } = options || {}; | ||
| if (!appConfig.router) { | ||
| appConfig.router = {}; | ||
| } | ||
| appConfig.router.type = 'static'; | ||
| return renderInServer(context, props, options); | ||
| return await renderInServer(context, props, options); |
ClarkXia
reviewed
Feb 25, 2021
| @@ -79,7 +79,9 @@ module.exports = function (api) { | |||
| // Remove outputDir when start devServer | |||
| const { outputDir = 'build' } = userConfig; | |||
| configs.forEach((config) => { | |||
| fs.emptyDirSync(path.resolve(rootDir, outputDir, config.name)); | |||
| if (config.name) { | |||
There was a problem hiding this comment.
document 没设置，我设置下也行
packages/plugin-rax-web/package.json
Outdated
| "chalk": "^4.1.0", | ||
| "html-minifier": "^4.0.0", | ||
| "cheerio": "1.0.0-rc.3" | ||
| "webpack": "^4.0.0", |
There was a problem hiding this comment.
这个依赖应该是可以移除的，底层 build-scripts 已经依赖了，如果 plugin-rax-web 有用到内置 webpack 插件的，可以从 context 上取
ClarkXia
reviewed
Feb 25, 2021
| let localBuildTask = registerListenTask(); | ||
|
|
||
| compiler.hooks.emit.tapAsync(PLUGIN_NAME, async (compilation, callback) => { | ||
| localBuildTask.then((localBuildAssets) => { |
There was a problem hiding this comment.
localBuildTask 是不是可以在 emit 阶段获取最新的
ClarkXia
approved these changes
Feb 25, 2021
chenjun1011
approved these changes
Feb 25, 2021
SoloJiang
added a commit
that referenced
this pull request
Feb 26, 2021
* chore: bump version * fix: data prefetches do not decamelize (#616) * [Refactor]: Document (#618) * chore: bump version * feat: support mpa spm (#591) * feat: support global css file in mpa (#592) * refactor: enhance ssr in SPA mode (#590) * fix: ssr document mode error * chore: add test case * fix: midway plugin ssr * feat: support getInitialData * fix: page component getInitial props in spa * chore: add window fallback * chore: optimize code * feat: support no document * feat: add document builder * chore: add local build plugin * chore: add emit * feat: no document with staticExport * feat: support hash in ssr * chore: revert example * chore: optimize code * chore: remove useless code * fix: app json content watch (#612) * Bump version (#620) * chore: bump version * chore: add changelog * chore: update version * chore: update version Co-authored-by: 岭伊 <zhengwang2314@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/app.js