Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement of cache adapter #13

Merged
merged 8 commits into from
Oct 7, 2022
Merged

Improvement of cache adapter #13

merged 8 commits into from
Oct 7, 2022

Conversation

koriym
Copy link
Member

@koriym koriym commented Jul 27, 2022

  • それぞれのアダプターのキャッシュネームスペースを有効に
  • FileSysmtemAdapterのキャッシュディレクトリ指定を有効に

@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #13 (02824c1) into 1.x (63a6d8a) will increase coverage by 64.40%.
The diff coverage is 100.00%.

@@              Coverage Diff               @@
##                1.x       #13       +/-   ##
==============================================
+ Coverage     35.59%   100.00%   +64.40%     
- Complexity       33        35        +2     
==============================================
  Files            22        21        -1     
  Lines           118        92       -26     
==============================================
+ Hits             42        92       +50     
+ Misses           76         0       -76     
Impacted Files Coverage Δ
src/Annotation/CacheDir.php 100.00% <ø> (+100.00%) ⬆️
src/Annotation/CacheNamespace.php 100.00% <ø> (+100.00%) ⬆️
src/FilesystemAdapter.php 100.00% <100.00%> (ø)
src/PhpFileAdapter.php 100.00% <100.00%> (ø)
src/Psr6RedisModule.php 100.00% <100.00%> (+100.00%) ⬆️
src/ApcuAdapter.php 100.00% <0.00%> (ø)
src/CacheDirModule.php 100.00% <0.00%> (ø)
src/Psr6NullModule.php 100.00% <0.00%> (ø)
src/Psr6ArrayModule.php 100.00% <0.00%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63a6d8a...02824c1. Read the comment docs.

@koriym koriym changed the title Revert continuous-integration.yml Improvement of FileSysmtemAdapter Jul 27, 2022
@koriym koriym changed the title Improvement of FileSysmtemAdapter Improvement of cache adapter Jul 27, 2022
@koriym koriym requested review from NaokiTsuchiya and a team July 27, 2022 23:55
@koriym koriym marked this pull request as ready for review July 28, 2022 14:37
@koriym
Copy link
Member Author

koriym commented Oct 5, 2022

@NaokiTsuchiya Gentle reminder

@koriym koriym merged commit b2717a3 into 1.x Oct 7, 2022
@koriym koriym deleted the fix-ci branch October 7, 2022 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants