Create Serializable Redis Adapter and ApcuAdapter disabled in CLI #17
+357
−171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## 1.x #17 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 42 46 +4
===========================================
Files 23 24 +1
Lines 106 110 +4
===========================================
+ Hits 106 110 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
koriym
force-pushed
the
serializable-redis-adapter
branch
from
5e648f6 to
7726b41
Compare
koriym
force-pushed
the
serializable-redis-adapter
branch
from
7726b41 to
9de40ee
Compare
koriym
force-pushed
the
serializable-redis-adapter
branch
from
b3e2e43 to
3350617
Compare
koriym
force-pushed
the
serializable-redis-adapter
branch
from
cc97860 to
ffcf079
Compare
koriym
force-pushed
the
serializable-redis-adapter
branch
from
ffcf079 to
c894dad
Compare
koriym
force-pushed
the
serializable-redis-adapter
branch
from
53ffdab to
aca7043
Compare
koriym
changed the title
koriym
commented
Apr 20, 2023
koriym
force-pushed
the
serializable-redis-adapter
branch
from
95049e1 to
aca7043
Compare
koriym
force-pushed
the
serializable-redis-adapter
branch
2 times, most recently
from
4a6e855 to
75b0f2c
Compare
koriym
force-pushed
the
serializable-redis-adapter
branch
from
75b0f2c to
7ce73db
Compare
Redis is not serializable.
koriym
force-pushed
the
serializable-redis-adapter
branch
from
fde3884 to
583db6f
Compare
src/Psr6RedisModule.php
Outdated
| // @codeCoverageIgnoreEnd | ||
| } | ||
|
|
||
| $this->bind(Redis::class); |
There was a problem hiding this comment.
新しく実装された RedisAdapter はシリアライズ可能にするために Providerを注入されるようになりましたが、
ここでのアンターゲット束縛は上記とは関係ないという理解であっていますかね？
Redis を束縛する場合は RedisProvider を使わないとコネクション情報などを利用できないのでこのアンターゲット束縛自体は意味がないのかなと。
There was a problem hiding this comment.
確かにここ不要です。suggest してもらっていいでしょうか？
| * @Named("redisProvider=redis") | ||
| */ | ||
| #[CacheNamespace('namespace')] | ||
| #[Named('redisProvider=redis')] |
There was a problem hiding this comment.
Provider注入であれば、 #Set を使うのはどうですかね？
Redis が Provider束縛であれば使えるんですかね。
redis is obtained from provider, so no bundling is required Co-authored-by: Naoki Tsuchiya <tsuchiya@bengo4.com>
NaokiTsuchiya
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RedisAdapterはシリアライズ不可能で、またRedisそのものもシリアライズしてしまうと復元したときに機能しないようでその点を対策したPRです。