Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add an e2e test for Autoscaler to scale up by manually updating minReplicas #2576

Closed
1 of 2 tasks
Tracked by #2173
kevin85421 opened this issue Nov 26, 2024 · 1 comment · Fixed by #2634
Closed
1 of 2 tasks
Tracked by #2173

[Feature] Add an e2e test for Autoscaler to scale up by manually updating minReplicas #2576

kevin85421 opened this issue Nov 26, 2024 · 1 comment · Fixed by #2634
Assignees
@LeoLiao123
Labels
1.3.0 autoscaler ci enhancement New feature or request good first issue Good for newcomers

Comments

@kevin85421
Copy link
Member

kevin85421 commented Nov 26, 2024 •
edited
Loading

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

Users may manually update minReplicas to a value greater than replicas. Then, KubeRay will create new Pods to ensure the worker group has $minReplicas Pods. It's the Autoscaler's duty to update replicas to ensure it is equal to or greater than minReplicas.

For this test,

  • Create a RayCluster with the Autoscaler enabled, containing a worker group with replicas: 1 and minReplicas: 0.
  • Update minReplicas from 0 to 2.
  • KubeRay should create an additional Pod.
  • Submit some Ray detached actors to trigger autoscaling to 5 Pods.
  • Verify whether the Autoscaler successfully scales up to 5 Pods.
  • Check whether replicas is set to 5.

Use case

No response

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@kevin85421 kevin85421 added enhancement New feature or request triage autoscaler good first issue Good for newcomers 1.3.0 ci and removed triage labels Nov 26, 2024
@kevin85421 kevin85421 mentioned this issue Nov 26, 2024
Open
15 tasks
@LeoLiao123
Copy link
Contributor

Hi @kevin85421 , I would like to take on this issue.

LeoLiao123 added a commit to LeoLiao123/kuberay that referenced this issue Dec 6, 2024
@LeoLiao123
[Feature] Add an e2e test for Autoscaler to scale up by manually upda…
7d9cd2a 
…ting minReplicas ray-project#2576

Signed-off-by: LeoLiao123 <leoyeepaa@gmail.com>
This was referenced Dec 6, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LeoLiao123 LeoLiao123

Labels
1.3.0 autoscaler ci enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
2 participants
@kevin85421 @LeoLiao123