[Test][Autoscaler][1/n] Add Ray Autoscaler e2e tests #2168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @rueian @MortalHappiness would you mind reviewing this PR? Thanks! |
|
cc @ryanaoleary would you mind reviewing this PR? Thanks! |
rueian
reviewed
May 29, 2024
Co-authored-by: Rueian <rueiancsie@gmail.com> Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org>
15 tasks
jjyao
reviewed
May 29, 2024
| . "github.com/ray-project/kuberay/ray-operator/test/support" | ||
| ) | ||
|
|
||
| func TestRayClusterAutoscaler(t *testing.T) { |
There was a problem hiding this comment.
A high level question: should we have all the testing logic inside python? like you can have a python script:
ray.init()
actor1 = Actor.remote()
assert ray.nodes() == 2
actor2 = Actor.remote()
assert ray.nodes() == 3
instead of doing the assertion in go?
There was a problem hiding this comment.
ray.init()
actor1 = Actor.remote()
assert ray.nodes() == 2
actor2 = Actor.remote()
assert ray.nodes() == 3This is something that the Ray Autoscaler needs to test. For the KubeRay node provider, we care more about whether the Pod is actually created. For Pods, Golang is much better than Python.
jjyao
approved these changes
May 29, 2024
rueian
added a commit
to rueian/kuberay
that referenced
this pull request
Jun 6, 2024
…ay-project#2168) Signed-off-by: Rueian <rueiancsie@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
See #2173 for more details.
Related issue number
Checks