[RayJob] Add Failure Feedback (log and event) for Failed k8s Creation Task #2306
+62
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rueian
reviewed
Aug 17, 2024
| @@ -508,6 +508,8 @@ func (r *RayJobReconciler) createNewK8sJob(ctx context.Context, rayJobInstance * | |||
|
|
|||
| // Create the Kubernetes Job | |||
| if err := r.Client.Create(ctx, job); err != nil { | |||
| logger.Error(err, "Failed to create new Kubernetes Job") | |||
| r.Recorder.Eventf(rayJobInstance, corev1.EventTypeWarning, "k8sJobCreationFailed", "Failed to create new Kubernetes Job %s: %v", job.Name, err) | |||
There was a problem hiding this comment.
"k8sJobCreationFailed" looks good to me. Would you mind changing the below "Created" to "k8sJobCreationCreated" as well?
rueian
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
When a Kubernetes Job cannot be successfully created, it logs the error and generates an event for the failed job creation.
Related issue number
Refer to #2210
Checks