[Feature] Add e2e tests for Autoscaler V2 #2588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simotw
force-pushed
the
feat/add-e2e-tests-for-autoscaler-v2
branch
from
d76f389 to
cc290a1
Compare
|
cc @MortalHappiness could you review this PR? Thanks! |
MortalHappiness
requested changes
Dec 3, 2024
2 tasks
|
Could you rebase with the master branch? |
simotw
force-pushed
the
feat/add-e2e-tests-for-autoscaler-v2
branch
from
ac01b0b to
c68329c
Compare
simotw
force-pushed
the
feat/add-e2e-tests-for-autoscaler-v2
branch
from
91974a0 to
1fcf213
Compare
MortalHappiness
requested changes
Dec 6, 2024
kevin85421
approved these changes
Dec 6, 2024
4 tasks
|
You can rebase with the master branch after #2620 is merged. |
|
keep failing |
|
I think this may be related to Ray Serve breaking changes. I will take a look at it. |
|
@simotw would you mind rebasing with the master branch again? Thanks! |
simotw
force-pushed
the
feat/add-e2e-tests-for-autoscaler-v2
branch
from
0e6f003 to
94598fe
Compare
lint fix test isolation fix lint refactoring update refactoring add missing subtest
simotw
force-pushed
the
feat/add-e2e-tests-for-autoscaler-v2
branch
from
94598fe to
77f63f0
Compare
Hi @kevin85421, I’ve rebased this branch onto the latest master and am currently running tests locally. Let me know if there’s anything else needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Add e2e tests for Autoscaler V2
Related issue number
Closes #2574
Checks
ScreenShots