Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] TestRayServiceInPlaceUpdate is flaky #2620

Merged
merged 2 commits into from
Dec 7, 2024
Merged

[Bug] TestRayServiceInPlaceUpdate is flaky #2620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9edd8ed
update
kevin85421 Dec 6, 2024
de813c8
update
kevin85421 Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/e2e-tests-reusable-workflow.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ jobs:

set -euo pipefail
cd ${{ inputs.dir-to-test }}
go test -timeout 30m -v ./test/e2e -json 2>&1 | tee ${KUBERAY_TEST_OUTPUT_DIR}/gotest.log | gotestfmt
go test -timeout 60m -v ./test/e2e -json 2>&1 | tee ${KUBERAY_TEST_OUTPUT_DIR}/gotest.log | gotestfmt

- name: Print KubeRay operator logs
if: (!inputs.plugin-test) && always() && steps.deploy.outcome == 'success'
Expand Down
16 changes: 9 additions & 7 deletions ray-operator/test/e2e/rayservice_in_place_update_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,14 @@ func TestRayServiceInPlaceUpdate(t *testing.T) {
}, TestTimeoutShort).Should(WithTransform(sampleyaml.IsPodRunningAndReady, BeTrue()))

// test the default curl result
// curl /fruit
stdout, _ := curlRayServicePod(test, rayService, curlPod, curlContainerName, "/fruit", `["MANGO", 2]`)
g.Expect(stdout.String()).To(Equal("6"))
// curl /calc
stdout, _ = curlRayServicePod(test, rayService, curlPod, curlContainerName, "/calc", `["MUL", 3]`)
g.Expect(stdout.String()).To(Equal("15 pizzas please!"))
g.Eventually(func(g Gomega) {
// curl /fruit
stdout, _ := curlRayServicePod(test, rayService, curlPod, curlContainerName, "/fruit", `["MANGO", 2]`)
g.Expect(stdout.String()).To(Equal("6"))
// curl /calc
stdout, _ = curlRayServicePod(test, rayService, curlPod, curlContainerName, "/calc", `["MUL", 3]`)
g.Expect(stdout.String()).To(Equal("15 pizzas please!"))
}, TestTimeoutShort).Should(Succeed())

// In-place update
// Parse ServeConfigV2 and replace the string in the simplest way to update it.
Expand All @@ -79,7 +81,7 @@ func TestRayServiceInPlaceUpdate(t *testing.T) {
// Test the new price and factor
g.Eventually(func(g Gomega) {
// curl /fruit
stdout, _ = curlRayServicePod(test, rayService, curlPod, curlContainerName, "/fruit", `["MANGO", 2]`)
stdout, _ := curlRayServicePod(test, rayService, curlPod, curlContainerName, "/fruit", `["MANGO", 2]`)
g.Expect(stdout.String()).To(Equal("8"))
// curl /calc
stdout, _ = curlRayServicePod(test, rayService, curlPod, curlContainerName, "/calc", `["MUL", 3]`)
Expand Down
Loading