Fix leader election failure and crd too long issue #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original name has a “.” which doesn’t meet requirement of DNS-1123 (subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character)
Since auto generated crd embed PodTemplateSpec, it results in some failures like `The CustomResourceDefinition "..." is invalid: metadata.annotations: Too long: must have at most 262144 characters`
Everytime we run `kubectl apply`, it will sets the kubectl.kubernetes.io/last-applied-configuration: '{...}' annotation on each object. The annotation contains the contents of the object configuration file that was used to create the object."
Using kubectl create helps workaround the issue but create will fail if crd exist so it need us to change logics to check and create.
In end end, we specify `maxDescLen` on controller-tools when generating the CRD and it helps reduce size.
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
* Fix leader election problem
Original name has a “.” which doesn’t meet requirement of DNS-1123 (subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character)
* Add README.md and CONTRIBUTING.md
* Fix crd too long issue
Since auto generated crd embed PodTemplateSpec, it results in some failures like `The CustomResourceDefinition "..." is invalid: metadata.annotations: Too long: must have at most 262144 characters`
Everytime we run `kubectl apply`, it will sets the kubectl.kubernetes.io/last-applied-configuration: '{...}' annotation on each object. The annotation contains the contents of the object configuration file that was used to create the object."
Using kubectl create helps workaround the issue but create will fail if crd exist so it need us to change logics to check and create.
In end end, we specify `maxDescLen` on controller-tools when generating the CRD and it helps reduce size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--leader-elect