[no_early_kickoff] [AIR] Deprecate TensorflowCheckpoint.get_model `…

…model_definition` parameter (#33776)

model_definition was deprecated in Ray 2.3 in favor of model. This PR escalates the deprecation warning to a deprecation error.

---------

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>

python/ray/train/tensorflow/tensorflow_checkpoint.py

@@ -223,13 +223,13 @@ def get_model(
         Returns:
             The Tensorflow Keras model stored in the checkpoint.
         """
+        # TODO: Remove `model_definition` in 2.6.
         if model_definition is not None:
-            warnings.warn(
+            raise DeprecationWarning(
                 "The `model_definition` parameter is deprecated. Use the `model` "
-                "parameter instead.",
-                DeprecationWarning,
+                "parameter instead."
             )
-            model = model_definition
+
         if model is not None and self._flavor is not self.Flavor.MODEL_WEIGHTS:
             warnings.warn(
                 "TensorflowCheckpoint was created from "

python/ray/train/tests/test_tensorflow_checkpoint.py

@@ -40,7 +40,7 @@ def get_model():
 def test_model_definition_raises_deprecation_warning():
     model = get_model()
     checkpoint = TensorflowCheckpoint.from_model(model)
-    with pytest.deprecated_call():
+    with pytest.raises(DeprecationWarning):
         checkpoint.get_model(model_definition=get_model)