fix

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
ray-project · Sep 25, 2024 · 5a0211a · 5a0211a
1 parent 04296c8
commit 5a0211a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/ray/core_worker/test/direct_actor_transport_test.cc b/src/ray/core_worker/test/direct_actor_transport_test.cc
@@ -626,7 +626,7 @@ TEST_P(ActorTaskSubmitterTest, TestActorRestartOutOfOrderGcs) {
   task = CreateActorTaskHelper(actor_id, worker_id, 4);
   EXPECT_CALL(*task_finisher_, FailOrRetryPendingTask(task.TaskId(), _, _, _, _, _))
       .Times(1);
-  ASSERT_FALSE(CheckSubmitTask(task));
+  ASSERT_TRUE(CheckSubmitTask(task));
 }
 
 TEST_P(ActorTaskSubmitterTest, TestActorRestartFailInflightTasks) {

diff --git a/src/ray/core_worker/transport/actor_task_submitter.cc b/src/ray/core_worker/transport/actor_task_submitter.cc
@@ -227,6 +227,9 @@ Status ActorTaskSubmitter::SubmitTask(TaskSpecification task_spec) {
         },
         "ActorTaskSubmitter::SubmitTask");
   } else {
+    // Post to the event loop to maintain the async nature of
+    // SubmitTask and avoid issues like
+    // https://github.com/ray-project/ray/issues/47606.
     io_service_.post(
         [this, task_spec, task_id]() {
           // Do not hold the lock while calling into task_finisher_.