Skip to content

Commit

Permalink
Remove urllib3 dependency (#36609)
Browse files Browse the repository at this point in the history
urllib3 was listed as a dependency under ray[k8s] (and therefore ray[all]), but upon inspection it seems it isn't actually used.

This PR removes urllib3 from the dependencies.

In this PR, ray[k8s] is also removed since urllib3 was the only dependency there. I confirmed manually that pip install ray[doesnotexist] doesn't fail, so this PR won't break any existing user scripts that contain pip install ray[k8s].

Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
  • Loading branch information
architkulkarni authored Jun 22, 2023
1 parent e14c9b1 commit 6a77bf7
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 8 deletions.
6 changes: 0 additions & 6 deletions python/ray/autoscaler/_private/autoscaler.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,12 +78,6 @@
)
from ray.core.generated import gcs_service_pb2, gcs_service_pb2_grpc

try:
from urllib3.exceptions import MaxRetryError
except ImportError:
MaxRetryError = None


logger = logging.getLogger(__name__)

# Status of a node e.g. "up-to-date", see ray/autoscaler/tags.py
Expand Down
1 change: 0 additions & 1 deletion python/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ colorful
pyyaml
rich
gpustat>=1.0.0
urllib3
opentelemetry-sdk
fastapi
virtualenv<20.21.1,>=20.0.24
Expand Down
1 change: 0 additions & 1 deletion python/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,6 @@ def get_packages(self):
],
"serve": ["uvicorn", "requests", "starlette", "fastapi", "aiorwlock"],
"tune": ["pandas", "tensorboardX>=1.9", "requests", pyarrow_dep],
"k8s": ["urllib3"],
"observability": [
"opentelemetry-api",
"opentelemetry-sdk",
Expand Down

0 comments on commit 6a77bf7

Please sign in to comment.