-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature][workflow] Namespace for workflow #18818
Comments
@iycheng can you share a little more details on the expected design? E.g. should the namespace act as physical checkpointing structure namespace as well? or should the namespace only affect the "names"? For the first choice, I meant we will have from: For the second choice, we will simply "append" the namespace to the "names": |
probably better to do the first option. i think we want to be able to operations like list or delete by namespace, so having the extra structure would help let us efficiently look things up by namespace. |
@wuisawesome @iycheng I am picking up this lost thread today, one question -
1 is easier-to-use and backward compatible. And it hides the notion of namespace for users who don't have the need for namespace. 2 gives more flexibility, and we can do cross-namespace operation. e.g. maybe I can use a virtual actor from namespace A to run my workflow in namespace B. But it involves adding namespace parameter to a LOT of apis as I could imagine. From "static" ones like Well, there is a way # 3, which does it in a hybrid way - we still make namespace a session scope but also add the parameter in all related individual functions and set value default to None. So if not given that parameter, it will pick the session's namespace, otherwise it will temporarily overwrite the session's default namespace. We can use a context manager similar to I haven't given enough thought on this but would like to know your thoughts here. |
@lchu-ibm I think way #3 is better
This is more aligned with ray's API
Basically by default namespace is None and if not given, it'll use the one from context otherwise, it'll use the given one. |
Search before asking
Description
In ray, we have already had a namespace concept which should be useful for workflow as well.
Recommend API should be:
Use case
No response
Related issues
No response
Are you willing to submit a PR?
The text was updated successfully, but these errors were encountered: