Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to make tests pass on Travis. #3

Merged
merged 7 commits into from
Oct 26, 2016
Merged

Changes to make tests pass on Travis. #3

merged 7 commits into from
Oct 26, 2016

Conversation

robertnishihara
Copy link
Collaborator

No description provided.

@pcmoritz pcmoritz merged commit f83a98d into master Oct 26, 2016
@pcmoritz pcmoritz deleted the subtree2 branch October 26, 2016 05:39
richardliaw referenced this pull request in richardliaw/ray Oct 3, 2017
@ericl
Merge pull request #3 from richardliaw/hp_refactor
37ef3cb 
Refactoring
@arvindc95 arvindc95 mentioned this pull request Oct 12, 2017
Closed
devin-petersohn referenced this pull request in devin-petersohn/ray Mar 16, 2018
@kunalgosar
fixing __delitem and initial pass at drop WIP (#3)
4e7e63d
devin-petersohn referenced this pull request in devin-petersohn/ray Mar 28, 2018
@kunalgosar @devin-petersohn
fixing __delitem and initial pass at drop WIP (#3)
d3076dc
romilbhardwaj added a commit to romilbhardwaj/ray that referenced this pull request Apr 8, 2019
@romilbhardwaj
� This is a combination of 4 commits.
f6740c7 
� This is the 1st commit message:

Rounding error fixes, removing cpu addition in cython and test fixes.

� This is the commit message ray-project#2:

Plumbing and support for dynamic custom resources.

� This is the commit message ray-project#3:

update cluster utils to use EntryType.

� This is the commit message ray-project#4:

Update node_manager to use new zero resource == deletion semantics.
rkooo567 referenced this pull request in rkooo567/ray Mar 24, 2020
@rkooo567
Merge pull request #3 from anyscale/grafana_integration
57c5e7f 
[Hosted Dashboard] Running Grafana instances with pre-configured dashboards.
bentzinir pushed a commit to bentzinir/ray that referenced this pull request Jul 29, 2020
@ron-amit
removing unnecessary changes ray-project#3
c9c53e6
sven1977 added a commit that referenced this pull request Dec 7, 2020
@sven1977
[RLlib] Attention Net prep PR #3. (#12450)
99c81c6
ericl added a commit that referenced this pull request Feb 19, 2021
@ericl
Fix deadlock in unhandled exception handler and re-merge (#3) (#14192)
cc156f7
ijrsvt pushed a commit that referenced this pull request Apr 23, 2021
@DmitriGekhtman
[client][placement groups] Client placement group hooks, attempt #3 (#…
0d0c241 
…15382)
@gshimansky gshimansky mentioned this pull request May 25, 2021
Closed
2 tasks
@krfricke krfricke mentioned this pull request Aug 23, 2021
Closed
@annaluo676 annaluo676 mentioned this pull request Sep 14, 2021
Closed
@lchu-ibm lchu-ibm mentioned this pull request Oct 11, 2021
Merged
6 tasks
@fishbone fishbone mentioned this pull request Dec 15, 2021
Open
2 tasks
@sven1977 sven1977 mentioned this pull request Jan 17, 2022
Merged
6 tasks
sven1977 added a commit that referenced this pull request Jan 25, 2022
@sven1977
[RLlib] Preparatory PR for multi-agent multi-GPU learner (alpha-star …
d5bfb7b 
…style) #3 (#21652)
@jiaodong jiaodong mentioned this pull request Feb 24, 2022
Merged
6 tasks
@scv119 scv119 mentioned this pull request Apr 4, 2022
Open
2 tasks
@clarkzinzow clarkzinzow mentioned this pull request Apr 10, 2022
Merged
6 tasks
ericl pushed a commit that referenced this pull request Apr 14, 2022
@clarkzinzow
[Datasets] [Out-of-Band Serialization: 1/3] Refactor LazyBlockList. (…
efc5ac5 
…#23821)

This PR refactors `LazyBlockList` in service of out-of-band serialization (see [mono-PR](#22616)) and is a precursor to an execution plan refactor (PR #2) and adding the actual out-of-band serialization APIs (PR #3). The following is included in this refactor:
1. `ReadTask`s are now a first-class concept, replacing calls;
2. read stage progress tracking is consolidated into `LazyBlockList._get_blocks_with_metadta()` and more of the read task complexity, e.g. the read remote function, was pushed into `LazyBlockList` to make `ray.data.read_datasource()` simpler;
3. we are a bit smarter with how we progressively launch tasks and fetch and cache metadata, including fetching the metadata for read tasks in `.iter_blocks_with_metadata()` instead of relying on the pre-read task metadata (which will be less accurate), and we also fix some small bugs in the lazy ramp-up around progressive metadata fetching.

(1) is the most important item for supporting out-of-band serialization and fundamentally changes the `LazyBlockList` data model. This is required since we need to be able to reference the underlying read tasks when rewriting read stages during optimization and when serializing the lineage of the Dataset. See the [mono-PR](#22616) for more context.

Other changes:
1. Changed stats actor to a global named actor singleton in order to obviate the need for serializing the actor handle with the Dataset stats; without this, we were encountering serialization failures.
@Peter-P779 Peter-P779 mentioned this pull request May 19, 2022
Closed
@chaomengyuan chaomengyuan mentioned this pull request Jun 15, 2022
Closed
kfstorm added a commit that referenced this pull request Jul 27, 2022
@kfstorm
[Core] No RAY_LOG in the constructor of DelayManager (#26958)
34d0233 
We encountered SIGSEGV when running Python test `python/ray/tests/test_failure_2.py::test_list_named_actors_timeout`. The stack is:

```
#0  0x00007fffed30f393 in std::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string(std::string const&) ()
   from /lib64/libstdc++.so.6
#1  0x00007fffee707649 in ray::RayLog::GetLoggerName() () from /home/admin/dev/Arc/merge/ray/python/ray/_raylet.so
#2  0x00007fffee70aa90 in ray::SpdLogMessage::Flush() () from /home/admin/dev/Arc/merge/ray/python/ray/_raylet.so
#3  0x00007fffee70af28 in ray::RayLog::~RayLog() () from /home/admin/dev/Arc/merge/ray/python/ray/_raylet.so
#4  0x00007fffee2b570d in ray::asio::testing::(anonymous namespace)::DelayManager::Init() [clone .constprop.0] ()
   from /home/admin/dev/Arc/merge/ray/python/ray/_raylet.so
#5  0x00007fffedd0d95a in _GLOBAL__sub_I_asio_chaos.cc () from /home/admin/dev/Arc/merge/ray/python/ray/_raylet.so
#6  0x00007ffff7fe282a in call_init.part () from /lib64/ld-linux-x86-64.so.2
#7  0x00007ffff7fe2931 in _dl_init () from /lib64/ld-linux-x86-64.so.2
#8  0x00007ffff7fe674c in dl_open_worker () from /lib64/ld-linux-x86-64.so.2
#9  0x00007ffff7b82e79 in _dl_catch_exception () from /lib64/libc.so.6
#10 0x00007ffff7fe5ffe in _dl_open () from /lib64/ld-linux-x86-64.so.2
#11 0x00007ffff7d5f39c in dlopen_doit () from /lib64/libdl.so.2
#12 0x00007ffff7b82e79 in _dl_catch_exception () from /lib64/libc.so.6
#13 0x00007ffff7b82f13 in _dl_catch_error () from /lib64/libc.so.6
#14 0x00007ffff7d5fb09 in _dlerror_run () from /lib64/libdl.so.2
#15 0x00007ffff7d5f42a in dlopen@@GLIBC_2.2.5 () from /lib64/libdl.so.2
#16 0x00007fffef04d330 in py_dl_open (self=<optimized out>, args=<optimized out>)
    at /tmp/python-build.20220507135524.257789/Python-3.7.11/Modules/_ctypes/callproc.c:1369
```

The root cause is that when loading `_raylet.so`, `static DelayManager _delay_manager` is initialized and `RAY_LOG(ERROR) << "RAY_testing_asio_delay_us is set to " << delay_env;` is executed. However, the static variables declared in `logging.cc` are not initialized yet (in this case, `std::string RayLog::logger_name_ = "ray_log_sink"`).

It's better not to rely on the initialization order of static variables in different compilation units because it's not guaranteed. I propose to change all `RAY_LOG`s to `std::cerr` in `DelayManager::Init()`.

The crash happens in Ant's internal codebase. Not sure why this test case passes in the community version though.

BTW, I've tried different approaches:

1. Using a static local variable in `get_delay_us` and remove the global variable. This doesn't work because `init()` needs to access the variable as well.
2. Defining the global variable as type `std::unique_ptr<DelayManager>` and initialize it in `get_delay_us`. This works but it requires a lock to be thread-safe.
Rohan138 pushed a commit to Rohan138/ray that referenced this pull request Jul 28, 2022
@kfstorm @Rohan138
[Core] No RAY_LOG in the constructor of DelayManager (ray-project#26958)
45f4633 
We encountered SIGSEGV when running Python test `python/ray/tests/test_failure_2.py::test_list_named_actors_timeout`. The stack is:

```
#0  0x00007fffed30f393 in std::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string(std::string const&) ()
   from /lib64/libstdc++.so.6
ray-project#1  0x00007fffee707649 in ray::RayLog::GetLoggerName() () from /home/admin/dev/Arc/merge/ray/python/ray/_raylet.so
ray-project#2  0x00007fffee70aa90 in ray::SpdLogMessage::Flush() () from /home/admin/dev/Arc/merge/ray/python/ray/_raylet.so
ray-project#3  0x00007fffee70af28 in ray::RayLog::~RayLog() () from /home/admin/dev/Arc/merge/ray/python/ray/_raylet.so
ray-project#4  0x00007fffee2b570d in ray::asio::testing::(anonymous namespace)::DelayManager::Init() [clone .constprop.0] ()
   from /home/admin/dev/Arc/merge/ray/python/ray/_raylet.so
ray-project#5  0x00007fffedd0d95a in _GLOBAL__sub_I_asio_chaos.cc () from /home/admin/dev/Arc/merge/ray/python/ray/_raylet.so
ray-project#6  0x00007ffff7fe282a in call_init.part () from /lib64/ld-linux-x86-64.so.2
ray-project#7  0x00007ffff7fe2931 in _dl_init () from /lib64/ld-linux-x86-64.so.2
ray-project#8  0x00007ffff7fe674c in dl_open_worker () from /lib64/ld-linux-x86-64.so.2
ray-project#9  0x00007ffff7b82e79 in _dl_catch_exception () from /lib64/libc.so.6
ray-project#10 0x00007ffff7fe5ffe in _dl_open () from /lib64/ld-linux-x86-64.so.2
ray-project#11 0x00007ffff7d5f39c in dlopen_doit () from /lib64/libdl.so.2
ray-project#12 0x00007ffff7b82e79 in _dl_catch_exception () from /lib64/libc.so.6
ray-project#13 0x00007ffff7b82f13 in _dl_catch_error () from /lib64/libc.so.6
ray-project#14 0x00007ffff7d5fb09 in _dlerror_run () from /lib64/libdl.so.2
ray-project#15 0x00007ffff7d5f42a in dlopen@@GLIBC_2.2.5 () from /lib64/libdl.so.2
ray-project#16 0x00007fffef04d330 in py_dl_open (self=<optimized out>, args=<optimized out>)
    at /tmp/python-build.20220507135524.257789/Python-3.7.11/Modules/_ctypes/callproc.c:1369
```

The root cause is that when loading `_raylet.so`, `static DelayManager _delay_manager` is initialized and `RAY_LOG(ERROR) << "RAY_testing_asio_delay_us is set to " << delay_env;` is executed. However, the static variables declared in `logging.cc` are not initialized yet (in this case, `std::string RayLog::logger_name_ = "ray_log_sink"`).

It's better not to rely on the initialization order of static variables in different compilation units because it's not guaranteed. I propose to change all `RAY_LOG`s to `std::cerr` in `DelayManager::Init()`.

The crash happens in Ant's internal codebase. Not sure why this test case passes in the community version though.

BTW, I've tried different approaches:

1. Using a static local variable in `get_delay_us` and remove the global variable. This doesn't work because `init()` needs to access the variable as well.
2. Defining the global variable as type `std::unique_ptr<DelayManager>` and initialize it in `get_delay_us`. This works but it requires a lock to be thread-safe. 

Signed-off-by: Rohan138 <rapotdar@purdue.edu>
Stefan-1313 pushed a commit to Stefan-1313/ray_mod that referenced this pull request Aug 18, 2022
@kfstorm
[Core] No RAY_LOG in the constructor of DelayManager (ray-project#26958)
b3de112 
We encountered SIGSEGV when running Python test `python/ray/tests/test_failure_2.py::test_list_named_actors_timeout`. The stack is:

```
#0  0x00007fffed30f393 in std::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string(std::string const&) ()
   from /lib64/libstdc++.so.6
ray-project#1  0x00007fffee707649 in ray::RayLog::GetLoggerName() () from /home/admin/dev/Arc/merge/ray/python/ray/_raylet.so
ray-project#2  0x00007fffee70aa90 in ray::SpdLogMessage::Flush() () from /home/admin/dev/Arc/merge/ray/python/ray/_raylet.so
ray-project#3  0x00007fffee70af28 in ray::RayLog::~RayLog() () from /home/admin/dev/Arc/merge/ray/python/ray/_raylet.so
ray-project#4  0x00007fffee2b570d in ray::asio::testing::(anonymous namespace)::DelayManager::Init() [clone .constprop.0] ()
   from /home/admin/dev/Arc/merge/ray/python/ray/_raylet.so
ray-project#5  0x00007fffedd0d95a in _GLOBAL__sub_I_asio_chaos.cc () from /home/admin/dev/Arc/merge/ray/python/ray/_raylet.so
ray-project#6  0x00007ffff7fe282a in call_init.part () from /lib64/ld-linux-x86-64.so.2
ray-project#7  0x00007ffff7fe2931 in _dl_init () from /lib64/ld-linux-x86-64.so.2
ray-project#8  0x00007ffff7fe674c in dl_open_worker () from /lib64/ld-linux-x86-64.so.2
ray-project#9  0x00007ffff7b82e79 in _dl_catch_exception () from /lib64/libc.so.6
ray-project#10 0x00007ffff7fe5ffe in _dl_open () from /lib64/ld-linux-x86-64.so.2
ray-project#11 0x00007ffff7d5f39c in dlopen_doit () from /lib64/libdl.so.2
ray-project#12 0x00007ffff7b82e79 in _dl_catch_exception () from /lib64/libc.so.6
ray-project#13 0x00007ffff7b82f13 in _dl_catch_error () from /lib64/libc.so.6
ray-project#14 0x00007ffff7d5fb09 in _dlerror_run () from /lib64/libdl.so.2
ray-project#15 0x00007ffff7d5f42a in dlopen@@GLIBC_2.2.5 () from /lib64/libdl.so.2
ray-project#16 0x00007fffef04d330 in py_dl_open (self=<optimized out>, args=<optimized out>)
    at /tmp/python-build.20220507135524.257789/Python-3.7.11/Modules/_ctypes/callproc.c:1369
```

The root cause is that when loading `_raylet.so`, `static DelayManager _delay_manager` is initialized and `RAY_LOG(ERROR) << "RAY_testing_asio_delay_us is set to " << delay_env;` is executed. However, the static variables declared in `logging.cc` are not initialized yet (in this case, `std::string RayLog::logger_name_ = "ray_log_sink"`).

It's better not to rely on the initialization order of static variables in different compilation units because it's not guaranteed. I propose to change all `RAY_LOG`s to `std::cerr` in `DelayManager::Init()`.

The crash happens in Ant's internal codebase. Not sure why this test case passes in the community version though.

BTW, I've tried different approaches:

1. Using a static local variable in `get_delay_us` and remove the global variable. This doesn't work because `init()` needs to access the variable as well.
2. Defining the global variable as type `std::unique_ptr<DelayManager>` and initialize it in `get_delay_us`. This works but it requires a lock to be thread-safe.

Signed-off-by: Stefan van der Kleij <s.vanderkleij@viroteq.com>
jaewan added a commit to jaewan/ray_memory_management that referenced this pull request Sep 13, 2022
@jaewan
Memory scheduling 2 DFS with Priority (ray-project#3)
00cfdef 
Implemented basic DFS priority assignment and task blocking and preemption.

Currently segfaults due to object already existing during task retry.
ericl pushed a commit that referenced this pull request Feb 27, 2023
@jianoaix
[Datasets] Streaming executor fixes #3 (#32836)
4cc3a53
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request Mar 21, 2023
@jianoaix @ProjectsByJackHe
[Datasets] Streaming executor fixes ray-project#3 (ray-project#32836)
916e318 
Signed-off-by: Jack He <jackhe2345@gmail.com>
peytondmurray referenced this pull request in peytondmurray/ray Mar 22, 2023
@jianoaix @peytondmurray
[Datasets] Streaming executor fixes #3 (ray-project#32836)
c9d4a41
elliottower pushed a commit to elliottower/ray that referenced this pull request Apr 22, 2023
@jianoaix @elliottower
[Datasets] Streaming executor fixes ray-project#3 (ray-project#32836)
903211e 
Signed-off-by: elliottower <elliot@elliottower.com>
@GokuMohandas GokuMohandas mentioned this pull request Apr 27, 2023
Merged
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
@jianoaix @ProjectsByJackHe
[Datasets] Streaming executor fixes ray-project#3 (ray-project#32836)
61d2cfd 
Signed-off-by: Jack He <jackhe2345@gmail.com>
@bveeramani bveeramani mentioned this pull request Jul 25, 2023
Merged
8 tasks
@architkulkarni architkulkarni mentioned this pull request Jul 27, 2023
Merged
8 tasks
sven1977 added a commit that referenced this pull request Dec 21, 2023
@sven1977
[RLlib] New ConnectorV2 API #3: Introduce actual ConnectorV2 API. (#…
bd555a0 
…41074) (#41212)
vickytsang pushed a commit to ROCm/ray that referenced this pull request Jan 12, 2024
@sven1977 @vickytsang
[RLlib] New ConnectorV2 API ray-project#3: Introduce actual `Connecto…
ad4e256 
…rV2` API. (ray-project#41074) (ray-project#41212)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertnishihara @pcmoritz