Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] batch inference docs #34567

Merged
merged 60 commits into from
May 2, 2023
Merged

[docs] batch inference docs #34567

merged 60 commits into from
May 2, 2023

Conversation

maxpumperla
Copy link
Contributor

@maxpumperla maxpumperla commented Apr 19, 2023 •
edited
Loading

@maxpumperla
wip
27659ae 
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
@maxpumperla
wip
5bd23cc 
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
@maxpumperla
Merge remote-tracking branch 'origin' into mp_batch_inference_docs
6a5eb70
@maxpumperla
Merge remote-tracking branch 'origin' into mp_batch_inference_docs
75c63eb
@maxpumperla maxpumperla requested a review from a team as a code owner April 19, 2023 12:44
@maxpumperla
actual quickstart examples
442f04f 
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
@maxpumperla
wip
7a43a90 
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
@maxpumperla
split quickstart
13e4508 
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
@maxpumperla
finish quick-start
a576d0e 
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
@amogkam amogkam self-assigned this Apr 19, 2023
amogkam

This comment was marked as resolved.

Sign in to view

@maxpumperla
move guides
29f047e 
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
@maxpumperla
simpler batch format script
6709713 
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
@maxpumperla
update
043bca3 
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
@maxpumperla
wrap
8ef3117 
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
@maxpumperla maxpumperla changed the title [WIP][docs] batch inference docs [docs] batch inference docs Apr 25, 2023
@maxpumperla
Merge branch 'master' into mp_batch_inference_docs
41d0516 
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
@maxpumperla
disable formatting for sample scripts
f883430 
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
@maxpumperla
Update user-guide.rst
deda16d 
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
@maxpumperla
wip
678e3f5 
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
@maxpumperla
wip
7897b21 
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
ericl
ericl reviewed Apr 28, 2023
View reviewed changes
doc/source/data/doc_code/hf_quick_start.py


# __hf_quickstart_prediction_start__
scale = ray.data.ActorPoolStrategy(2)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
scale = ray.data.ActorPoolStrategy(2)
scale = ray.data.ActorPoolStrategy(size=2)

Kwargs will be required in strict mode for actor pool strategy.

ericl
ericl reviewed Apr 28, 2023
View reviewed changes
doc/source/data/batch_inference.rst
ndarrays (``Dict[str, np.ndarray]``), with each key-value pair representing a column
in the table.

* **Tensor datasets** (single-column): Each batch will be a single
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be disallowed in strict mode.

ericl
ericl reviewed Apr 28, 2023
View reviewed changes
Copy link
Contributor

@ericl ericl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The strict mode by default PR is ahead of schedule--- we can likely merge by end of today. Given this, how about making the new doc directly for the new API?

maxpumperla and others added 4 commits April 29, 2023 09:50
@maxpumperla @angelinalg
Update doc/source/data/doc_code/pytorch_quick_start.py
e6b60cd 
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
@maxpumperla @angelinalg
Update doc/source/data/doc_code/pytorch_quick_start.py
d552027 
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
@maxpumperla @angelinalg
Update doc/source/data/batch_inference.rst
fe0d9cc 
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
@maxpumperla @angelinalg
Update doc/source/data/doc_code/pytorch_quick_start.py
62a8608 
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
@maxpumperla
Copy link
Contributor Author

@ericl the reason is that we wanted to merge this soon, and then follow up with the latest changes. I think it's valuable to have a 2.4 snapshot and then apply the delta of the API changes. That's what we agreed on in the Data standup. If you insist, I can make the changes now.

@pcmoritz @zhe-thoughts any thoughts?

@zhe-thoughts
Copy link
Collaborator

@ericl @pcmoritz @maxpumperla @amogkam : Yes I think let's merge this one first and have a follow-up to reflect changes for strict mode. Not a big deal, but structurally it's easier to understand

ericl
ericl reviewed May 1, 2023
View reviewed changes
doc/source/_toc.yml Outdated Show resolved Hide resolved
ericl
ericl approved these changes May 1, 2023
View reviewed changes
Copy link
Contributor

@ericl ericl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds pretty good. Can you address the TOC order change though? That is my only blocking comment.

@ericl ericl added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label May 1, 2023
pcmoritz
pcmoritz approved these changes May 1, 2023
View reviewed changes
Copy link
Contributor

@pcmoritz pcmoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's do the strict mode simplifications as a follow up. It will get a bunch simpler 🥳

maxpumperla added 2 commits May 2, 2023 07:42
@maxpumperla
Update _toc.yml
0ac2515 
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
@maxpumperla
Update _toc.yml
a904e1d 
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
@krfricke krfricke merged commit 1564c51 into master May 2, 2023
@krfricke krfricke deleted the mp_batch_inference_docs branch May 2, 2023 08:59
architkulkarni pushed a commit to architkulkarni/ray that referenced this pull request May 16, 2023
@maxpumperla @angelinalg @architkulkarni
[docs] batch inference docs (ray-project#34567)
4b6a37b 
Preview: https://anyscale-ray--34567.com.readthedocs.build/en/34567/data/batch_inference.html

Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
@zhe-thoughts zhe-thoughts mentioned this pull request May 19, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelinalg angelinalg angelinalg left review comments

@amogkam amogkam amogkam left review comments

@krfricke krfricke krfricke approved these changes

@pcmoritz pcmoritz pcmoritz approved these changes

@ericl ericl ericl approved these changes

@richardliaw richardliaw Awaiting requested review from richardliaw

@gjoliver gjoliver Awaiting requested review from gjoliver

@xwjiang2010 xwjiang2010 Awaiting requested review from xwjiang2010

@matthewdeng matthewdeng Awaiting requested review from matthewdeng

@Yard1 Yard1 Awaiting requested review from Yard1

@scv119 scv119 Awaiting requested review from scv119

@c21 c21 Awaiting requested review from c21

@scottjlee scottjlee Awaiting requested review from scottjlee

@bveeramani bveeramani Awaiting requested review from bveeramani

Assignees

@maxpumperla maxpumperla

Labels
@author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@maxpumperla @GokuMohandas @zhe-thoughts @ericl @pcmoritz @amogkam @krfricke @angelinalg