Release test aggregate_benchmark.aws failed #48176
Labels
bug
Something that is supposed to be working; but isn't
data
Ray Data-related issues
jailed-test
Indicate that this test is jailed and will stop running in CI/CD
P0
Issues that should be fixed in short order
ray-test-bot
Issues managed by OSS test policy
release-test
release test
stability
triage
Needs triage (eg: priority, bug/not-bug, and owning component)
weekly-release-blocker
Issues that will be blocking Ray weekly releases
Comments
can-anyscale
added
bug
|
Blamed commit: 26bdd94 found by bisect job https://buildkite.com/ray-project/release-tests-bisect/builds/1640 |
|
Test has been failing for far too long. Jailing. |
can-anyscale
added
the
jailed-test
|
fixed, to confirm |
|
Fixed by #48209 |
|
Re-opening issue as test is still failing. Latest run: https://buildkite.com/ray-project/release/builds/24456#0192c241-79d5-4d01-946c-5fd92916f3c1 |
8 tasks
scottjlee
added a commit
that referenced
this issue
Oct 25, 2024
## Why are these changes needed? #48126 introduced a `LogicalOperator` for calculating `Dataset.count()`. As an unintended side effect, calculating `sum()` over numpy batches can result in returning `np.int64` instead of a regular `int`. This PR explicitly cases the result to an `int` before returning. ## Related issue number Closes #48177, #48176 ## Checks - [x] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [x] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [x] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [x] Unit tests - [x] Release tests - [ ] This PR is not tested :( Signed-off-by: Scott Lee <sjl@anyscale.com>
|
Test passed on latest run: https://buildkite.com/ray-project/release/builds/24591#0192c756-9cdf-45cf-a22a-4558fe96756e |
Jay-ju
pushed a commit
to Jay-ju/ray
that referenced
this issue
Nov 5, 2024
## Why are these changes needed? ray-project#48126 introduced a `LogicalOperator` for calculating `Dataset.count()`. As an unintended side effect, calculating `sum()` over numpy batches can result in returning `np.int64` instead of a regular `int`. This PR explicitly cases the result to an `int` before returning. ## Related issue number Closes ray-project#48177, ray-project#48176 ## Checks - [x] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [x] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [x] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [x] Unit tests - [x] Release tests - [ ] This PR is not tested :( Signed-off-by: Scott Lee <sjl@anyscale.com>
JP-sDEV
pushed a commit
to JP-sDEV/ray
that referenced
this issue
Nov 14, 2024
## Why are these changes needed? ray-project#48126 introduced a `LogicalOperator` for calculating `Dataset.count()`. As an unintended side effect, calculating `sum()` over numpy batches can result in returning `np.int64` instead of a regular `int`. This PR explicitly cases the result to an `int` before returning. ## Related issue number Closes ray-project#48177, ray-project#48176 ## Checks - [x] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [x] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [x] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [x] Unit tests - [x] Release tests - [ ] This PR is not tested :( Signed-off-by: Scott Lee <sjl@anyscale.com>
mohitjain2504
pushed a commit
to mohitjain2504/ray
that referenced
this issue
Nov 15, 2024
## Why are these changes needed? ray-project#48126 introduced a `LogicalOperator` for calculating `Dataset.count()`. As an unintended side effect, calculating `sum()` over numpy batches can result in returning `np.int64` instead of a regular `int`. This PR explicitly cases the result to an `int` before returning. ## Related issue number Closes ray-project#48177, ray-project#48176 ## Checks - [x] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [x] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [x] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [x] Unit tests - [x] Release tests - [ ] This PR is not tested :( Signed-off-by: Scott Lee <sjl@anyscale.com> Signed-off-by: mohitjain2504 <mohit.jain@dream11.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Release test aggregate_benchmark.aws failed. See https://buildkite.com/ray-project/release/builds/24221#0192b2c2-d3d3-4b5b-9cf8-51e87286c14f for more details.
Managed by OSS Test Policy
The text was updated successfully, but these errors were encountered: