Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUILD: patch zlib for macos and protobuf for windows #48794

Open
mattip opened this issue Nov 19, 2024 · 3 comments
Open

BUILD: patch zlib for macos and protobuf for windows #48794

mattip opened this issue Nov 19, 2024 · 3 comments
Labels
bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component)

Comments

@mattip
Copy link
Contributor

mattip commented Nov 19, 2024

What happened + What you expected to happen

Over at conda-forge I needed to patch the grpc, boost, and prometheus-cpp build recipes to remove fdopen from zlib, which fails to compile when conda-forge updated to the azure macOS-13 image. The change is part of zlib-1.3.1.

I also needed to patch protobuf for newer windows SDK which no longer has a constant NAN, here is the upstream fix.

I think the best way forward would be to update the dependencies, but that might have unintended consequences. I could submit the patches I developed for the conda-forge build here, would that be welcome?

Versions / Dependencies

ray-2.39.0 built on Azure CI via conda-forge

Reproduction script

bazel --verbose_failures --local_cpu_resources=4 -- //:ray_pkg

Issue Severity

Medium: It is a significant difficulty but I can work around it.

@mattip mattip added bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Nov 19, 2024
@jjyao
Copy link
Collaborator

jjyao commented Nov 19, 2024

Let's try to upgrade, if it's hard we can patch.

@mattip
Copy link
Contributor Author

mattip commented Nov 20, 2024

It may not be easy to upgrade.

@jjyao
Copy link
Collaborator

jjyao commented Nov 20, 2024

Let's patch then to unblock the conda release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component)
Projects
None yet
Development

No branches or pull requests

2 participants