Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ray-packages v2.39.0 #188

Open
wants to merge 26 commits into
base: main
Choose a base branch
from

Conversation

regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Pending Dependency Version Updates

Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.

Name Upstream Version Current Version
bazel 7.4.1 Anaconda-Server Badge
opencensus 0.11.4-1.1.13 Anaconda-Server Badge
opentelemetry-exporter-otlp 1.28.1 Anaconda-Server Badge
opentelemetry-sdk 1.28.1 Anaconda-Server Badge
protobuf 28.3 Anaconda-Server Badge
ray-packages 2.39.0 Anaconda-Server Badge

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/11828694084 - please use this URL for debugging.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

  • ❌ Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [139]

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@mattip
Copy link
Contributor

mattip commented Nov 14, 2024

I forced macOS-12. FWIW, the upstream uses buildkite. I think they are using apple silicon macos 14.5. Here is the buildkit equivalent to a github workflow used by ray for macos. In #187 I had tried using Azure's macOS-14 but it did not work.

@mattip
Copy link
Contributor

mattip commented Nov 14, 2024

macos arm64 is failing due to a definition of fdopen

ERROR: /Users/runner/miniforge3/conda-bld/ray-packages_1731575330608/_build_env/share/bazel/32b6801a9cb0b3c9fa3440a569329aa8/external/zlib/BUILD.bazel:1:11: Compiling zutil.c [for tool] failed: (Exit 1): cc_wrapper_build.sh failed: error executing command (from target @zlib//:zlib) 
  (cd /Users/runner/miniforge3/conda-bld/ray-packages_1731575330608/_build_env/share/bazel/32b6801a9cb0b3c9fa3440a569329aa8/sandbox/darwin-sandbox/802/execroot/com_github_ray_project_ray && \
  exec env - \
    PATH=/Users/runner/miniforge3/conda-bld/ray-packages_1731575330608/_build_env/bin:/Users/runner/miniforge3/conda-bld/ray-packages_1731575330608/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/bin:/Users/runner/miniforge3/condabin:/Users/runner/miniforge3/bin:/Users/runner/miniforge3/condabin:/usr/local/lib/ruby/gems/3.0.0/bin:/usr/local/opt/ruby@3.0/bin:.:/usr/local/bin:/usr/local/sbin:/Users/runner/bin:/Library/Frameworks/Python.framework/Versions/Current/bin:/Library/Frameworks/Mono.framework/Versions/Current/Commands:/usr/bin:/bin:/usr/sbin:/sbin:/Users/runner/.ghcup/bin \
    PWD=/proc/self/cwd \
  bazel_toolchain/cc_wrapper_build.sh -MD -MF bazel-out/darwin-opt-exec-2B5CBBC6/bin/external/zlib/_objs/zlib/zutil.d '-frandom-seed=bazel-out/darwin-opt-exec-2B5CBBC6/bin/external/zlib/_objs/zlib/zutil.o' '-DBAZEL_CURRENT_REPOSITORY="zlib"' -iquote external/zlib -iquote bazel-out/darwin-opt-exec-2B5CBBC6/bin/external/zlib -isystem external/zlib -isystem bazel-out/darwin-opt-exec-2B5CBBC6/bin/external/zlib -isystem /Users/runner/miniforge3/conda-bld/ray-packages_1731575330608/_build_env/include/c++/v1 -isystem /Users/runner/miniforge3/conda-bld/ray-packages_1731575330608/_build_env/lib/clang/18.1.8/include -isystem /Applications/Xcode_14.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk/usr/include -isystem /Applications/Xcode_14.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk/System/Library/Frameworks -isystem /Users/runner/miniforge3/conda-bld/ray-packages_1731575330608/_build_env/include -ftree-vectorize -fPIC -fstack-protector-strong -O2 -pipe -isystem /Users/runner/miniforge3/conda-bld/ray-packages_1731575330608/_build_env/include '-fdebug-prefix-map=/Users/runner/miniforge3/conda-bld/ray-packages_1731575330608/work=/usr/local/src/conda/ray-core-2.39.0' '-fdebug-prefix-map=/Users/runner/miniforge3/conda-bld/ray-packages_1731575330608/_build_env=/usr/local/src/conda-prefix' '-D_FORTIFY_SOURCE=2' -isystem /Users/runner/miniforge3/conda-bld/ray-packages_1731575330608/_build_env/include '-mmacosx-version-min=11.0' '-mmacosx-version-min=11.0' -g0 -w -c external/zlib/zutil.c -o bazel-out/darwin-opt-exec-2B5CBBC6/bin/external/zlib/_objs/zlib/zutil.o)
# Configuration: 962447247c96cf2b94b8d728cb75dc5b59ba193c5b3eeb5273bedd9bd31258f9
# Execution platform: @local_config_platform//:host

Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
In file included from external/zlib/zutil.c:10:
In file included from external/zlib/gzguts.h:20:
In file included from /Users/runner/miniforge3/conda-bld/ray-packages_1731575330608/_build_env/include/c++/v1/stdio.h:108:
/Applications/Xcode_14.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk/usr/include/stdio.h:210:7: error: expected identifier or '('
  210 | FILE    *fdopen(int, const char *) __DARWIN_ALIAS_STARTING(__MAC_10_6, __IPHONE_2_0, __DARWIN_ALIAS(fdopen));
      |          ^
external/zlib/zutil.h:147:33: note: expanded from macro 'fdopen'
  147 | #        define fdopen(fd,mode) NULL /* No fdopen() */

zlib.h removed the unused fdopen declaration before 1.3.1. I wonder which bazel build package is pulling it in so I can create a patch

@mattip
Copy link
Contributor

mattip commented Nov 14, 2024

I see there is a patch file for zlib in the prometheus-cpp bazel rule needed for OpenCensus, and indeed checking out prometheus-cpp at commit 60eaa4ea47b16751a8e8740 contains zlib 1.2.11. This is a prometheus-cpp from Nov 2019, and OpenCensus itself is from Jan 2023. Since then, OpenCensus has been sunset, and development moved to OpenTelemetry. I don't see concrete plans on the ray issue tracker to move to OpenTelemtry. So I guess the "easiest" thing to do will be to create a patch based on this changeset

@mattip
Copy link
Contributor

mattip commented Nov 18, 2024

Gr8. Windows are failing with protobuf issues around constant NAN and the latest windows SDK.

@mattip
Copy link
Contributor

mattip commented Nov 18, 2024

For future reference: to download and expand all the bazel sources, and apply the patches, without compiling, do something like this:

bazel --output_user_root=/tmp/bazel-root build --verbose-failures --local_cpu_resources=4 -- //:ray_pkg

The first compilation step tries to cythonize a file, so as long as python fails (not python3, just python) the build will stop after expanding everything.

@mattip
Copy link
Contributor

mattip commented Nov 19, 2024

Bleh. macOS deprecated char_traits<fmt::detail::char8_type>. File ./src/ray/common/file_system_monitor.h fails at #include <filesystem> after #include <gtest/gtest_prod.h>. I wonder if the order of includes is triggering the error. It seems the offending file is

external/com_github_spdlog/_virtual_includes/spdlog/spdlog/fmt/bundled/core.h

Probably another case of ray-project/ray#35200. Upstream uses spdlog 1.12, but 1.15 is available. I don't see anything relevant in the changelogs? I will try switching header order.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). Your recipe may not receive automatic updates and/or may not be compatible with conda-forge's infrastructure. Please check the logs for more information and ensure your recipe can be parsed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants