[Tune] Fix "ValueError: I/O operation on closed file" #31269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeroen Bédorf <jeroen@bedorf.net>
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
|
stale
bot
added
the
stale
|
Ping to keep this open |
stale
bot
removed
the
stale
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
Mar 21, 2023
) Certain third party libraries modify the logging streams (e.g. mlflow, structlog). If those are combined with the Tune `log_to_file` option then you get ValueErrors. This PR prevents those errors and issues a warning instead. This way the functionality stays useful and the run won't fail. Signed-off-by: Jeroen Bédorf <jeroen@bedorf.net> Signed-off-by: Jack He <jackhe2345@gmail.com>
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
) Certain third party libraries modify the logging streams (e.g. mlflow, structlog). If those are combined with the Tune `log_to_file` option then you get ValueErrors. This PR prevents those errors and issues a warning instead. This way the functionality stays useful and the run won't fail. Signed-off-by: Jeroen Bédorf <jeroen@bedorf.net> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
peytondmurray
pushed a commit
to peytondmurray/ray
that referenced
this pull request
Mar 22, 2023
) Certain third party libraries modify the logging streams (e.g. mlflow, structlog). If those are combined with the Tune `log_to_file` option then you get ValueErrors. This PR prevents those errors and issues a warning instead. This way the functionality stays useful and the run won't fail. Signed-off-by: Jeroen Bédorf <jeroen@bedorf.net>
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
) Certain third party libraries modify the logging streams (e.g. mlflow, structlog). If those are combined with the Tune `log_to_file` option then you get ValueErrors. This PR prevents those errors and issues a warning instead. This way the functionality stays useful and the run won't fail. Signed-off-by: Jeroen Bédorf <jeroen@bedorf.net> Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
) Certain third party libraries modify the logging streams (e.g. mlflow, structlog). If those are combined with the Tune `log_to_file` option then you get ValueErrors. This PR prevents those errors and issues a warning instead. This way the functionality stays useful and the run won't fail. Signed-off-by: Jeroen Bédorf <jeroen@bedorf.net> Signed-off-by: Jack He <jackhe2345@gmail.com>
8 tasks
krfricke
added a commit
that referenced
this pull request
Jun 23, 2023
Currently there is a possibility of an infinite stack recursion in our log redirection logic: - We redirect `sys.stderr` (which is e.g. used by loggers per default) to a `Tee` object - This objects redirects the data into a file and into the original stream (`sys.stdout`) - The original `sys.stderr` can be closed e.g. by other libraries - After #31269, we warn if we can't write to a stream. However, if this stream is `sys.stderr`, the warning log will trigger the `Tee` processing again - We end up in an infinite recursion. The solution in this PR is to add a flag that we set and unset before and after emitting the logging message. If it is detected at the start of the function call, we are in a recursion and exit early. Signed-off-by: Kai Fricke <kai@anyscale.com>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
Currently there is a possibility of an infinite stack recursion in our log redirection logic: - We redirect `sys.stderr` (which is e.g. used by loggers per default) to a `Tee` object - This objects redirects the data into a file and into the original stream (`sys.stdout`) - The original `sys.stderr` can be closed e.g. by other libraries - After ray-project#31269, we warn if we can't write to a stream. However, if this stream is `sys.stderr`, the warning log will trigger the `Tee` processing again - We end up in an infinite recursion. The solution in this PR is to add a flag that we set and unset before and after emitting the logging message. If it is detected at the start of the function call, we are in a recursion and exit early. Signed-off-by: Kai Fricke <kai@anyscale.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jeroen Bédorf jeroen@bedorf.net
Why are these changes needed?
Certain third party libraries modify the logging streams (e.g. mlflow, structlog). If those are combined with the Tune
log_to_fileoption then you get ValueErrors. This PR prevents those errors and issues a warning instead. This way the functionality stays useful and the run won't fail.Related issue number
Closes #31096
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.