Fix cuda docker image references #31385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kornél Csernai <749306+csko@users.noreply.github.com>
|
Btw, does the build still work with our docker files? (are they compatible with 18.04)? |
I'm not super familiar with the build system, but in the 3.11 PR (#31170) it seemed to work with earlier. |
|
Would you be able to merge this? What's the best way to test this? cc @rickyyx |
|
Interesting - I'm wondering why this doesn't end up with a broken build at the moment. |
|
Anyway, I'll merge this for now, but we should investigate. |
AmeerHajAli
pushed a commit
that referenced
this pull request
Jan 12, 2023
There is no ubuntu20.04 image for cuda 10.2 and 10.1. Signed-off-by: Kornél Csernai <749306+csko@users.noreply.github.com>
tamohannes
pushed a commit
to ju2ez/ray
that referenced
this pull request
Jan 25, 2023
There is no ubuntu20.04 image for cuda 10.2 and 10.1. Signed-off-by: Kornél Csernai <749306+csko@users.noreply.github.com> Signed-off-by: tmynn <hovhannes.tamoyan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kornél Csernai 749306+csko@users.noreply.github.com
Why are these changes needed?
There is no ubuntu20.04 image for cuda 10.2 and 10.1.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.