-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci/release] Use job-based file manager for SDK runner per default #31493
Merged
rkooo567
merged 1 commit into
ray-project:master
from
krfricke:ci/release/jobs-file-manager
Jan 6, 2023
Merged
[ci/release] Use job-based file manager for SDK runner per default #31493
rkooo567
merged 1 commit into
ray-project:master
from
krfricke:ci/release/jobs-file-manager
Jan 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai Fricke <kai@anyscale.com>
rkooo567
approved these changes
Jan 6, 2023
Can you monitor if infra failures are increasing? |
Will do! |
AmeerHajAli
pushed a commit
that referenced
this pull request
Jan 12, 2023
…31493) Signed-off-by: Kai Fricke <kai@anyscale.com> Release tests are currently failing with an error on file upload (botocore.exceptions.DataNotFoundError: Unable to load data for: ec2/2016-11-15/endpoint-rule-set-1). This is likely because some tests are using an anyscale push-based API to upload files. By switching to the job-based filemanager for all tests the upload issue should be mitigated. Please note that execution will still happen with SDK commands for those tests that haven't specified to use jobs for execution, so actual test execution should be unaffected.
7 tasks
clarkzinzow
pushed a commit
that referenced
this pull request
Jan 19, 2023
…enchmark_single_node test (#31752) The release test read_parquet_benchmark_single_node has been failing for the past several master builds (examples 1, 2), due to the same issue discussed/addressed in #31493 (the actual error message is: botocore.exceptions.DataNotFoundError: Unable to load data for: ec2/2016-11-15/endpoint-rule-set-1). This PR updates one remaining test to match this convention. Signed-off-by: Scott Lee <sjl@anyscale.com>
andreapiso
pushed a commit
to andreapiso/ray
that referenced
this pull request
Jan 22, 2023
…enchmark_single_node test (ray-project#31752) The release test read_parquet_benchmark_single_node has been failing for the past several master builds (examples 1, 2), due to the same issue discussed/addressed in ray-project#31493 (the actual error message is: botocore.exceptions.DataNotFoundError: Unable to load data for: ec2/2016-11-15/endpoint-rule-set-1). This PR updates one remaining test to match this convention. Signed-off-by: Scott Lee <sjl@anyscale.com> Signed-off-by: Andrea Pisoni <andreapiso@gmail.com>
7 tasks
amogkam
pushed a commit
that referenced
this pull request
Jan 23, 2023
…tches_benchmark_single_node test (#31864) The release test iter_tensor_batches_benchmark_single_node has failed the most recent run, due to the same issue discussed/addressed in #31752 and #31493 (the actual error message is: botocore.exceptions.DataNotFoundError: Unable to load data for: ec2/2016-11-15/endpoint-rule-set-1). This PR updates one remaining test to match this convention. Signed-off-by: Scott Lee <sjl@anyscale.com>
tamohannes
pushed a commit
to ju2ez/ray
that referenced
this pull request
Jan 25, 2023
…ay-project#31493) Signed-off-by: Kai Fricke <kai@anyscale.com> Release tests are currently failing with an error on file upload (botocore.exceptions.DataNotFoundError: Unable to load data for: ec2/2016-11-15/endpoint-rule-set-1). This is likely because some tests are using an anyscale push-based API to upload files. By switching to the job-based filemanager for all tests the upload issue should be mitigated. Please note that execution will still happen with SDK commands for those tests that haven't specified to use jobs for execution, so actual test execution should be unaffected. Signed-off-by: tmynn <hovhannes.tamoyan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kai Fricke kai@anyscale.com
Why are these changes needed?
Release tests are currently failing with an error on file upload (
botocore.exceptions.DataNotFoundError: Unable to load data for: ec2/2016-11-15/endpoint-rule-set-1
). This is likely because some tests are using ananyscale push
-based API to upload files. By switching to the job-based filemanager for all tests the upload issue should be mitigated.Please note that execution will still happen with SDK commands for those tests that haven't specified to use jobs for execution, so actual test execution should be unaffected.
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.