[AIR] Automatically move DatasetIterator torch tensors to correct device
#31753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
amogkam
changed the title
DatasetIterator torch tensors to correct device
7 tasks
amogkam
requested review from
richardliaw,
gjoliver,
krfricke,
xwjiang2010,
matthewdeng,
Yard1,
maxpumperla,
a team,
ericl,
scv119,
clarkzinzow,
jjyao,
jianoaix and
c21
as code owners
clarkzinzow
approved these changes
Feb 9, 2023
| try: | ||
| device = get_device() | ||
| except SessionMisuseError: | ||
| pass |
There was a problem hiding this comment.
So this error is raised when a Train session is never initialized, right? Are we ignoring the error here in case this iterator is used outside of a Ray Train context, making this ~a no-op?
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
…evice (ray-project#31753) When DatasetIterator is used with Ray Train, automatically move the torch tensors returned by iter_torch_batches to the correct device. Signed-off-by: amogkam <amogkamsetty@yahoo.com> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
DatasetIteratoris used with Ray Train, automatically move the torch tensors returned byiter_torch_batchesto the correct device.Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.