Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] release test for nested air (tune) oom #31768

Merged
merged 4 commits into from
Feb 3, 2023

Conversation

clarng
Copy link
Contributor

@clarng clarng commented Jan 19, 2023

Why are these changes needed?

OOM Release test for nested task graph, using AIR (Tune)

This is still testing on existing (lifo) policy, which we will switch to group-by-owner once #31272 is merged and we change the default policy to group-by-owner

Related issue number

#31508

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Clarence Ng <clarence.wyng@gmail.com>
Signed-off-by: Clarence Ng <clarence.wyng@gmail.com>
@clarng clarng marked this pull request as ready for review January 19, 2023 21:46
Signed-off-by: Clarence Ng <clarence@anyscale.com>
@clarng clarng requested a review from scv119 January 27, 2023 00:32
@clarng clarng added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Jan 27, 2023
@scv119
Copy link
Contributor

scv119 commented Jan 30, 2023

@clarng
Copy link
Contributor Author

clarng commented Jan 30, 2023

Signed-off-by: Clarence Ng <clarence.wyng@gmail.com>
@clarng
Copy link
Contributor Author

clarng commented Feb 1, 2023

Looks green with latest run: https://buildkite.com/ray-project/release-tests-pr/builds/27296

@scv119 scv119 merged commit 370a574 into ray-project:master Feb 3, 2023
edoakes pushed a commit to edoakes/ray that referenced this pull request Mar 22, 2023
[core] release test for nested air (tune) oom ray-project#31768

Signed-off-by: Clarence Ng <clarence@anyscale.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants