Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tune] Improve logging, unify trial retry logic, improve trial restore retry test. #32242

Merged
merged 7 commits into from
Feb 10, 2023

Conversation

xwjiang2010
Copy link
Contributor

Directly ported from #31701, which was accidentally closed.

Signed-off-by: xwjiang2010 xwjiang2010@gmail.com

  1. Logging changes:

Before:

2023-01-11 14:02:44,582	ERROR trial_runner.py:1094 -- Trial TorchTrainer_6ce0b_00000: Error processing event.

After:

2023-01-11 14:02:44,582	ERROR trial_runner.py:1094 -- Trial TorchTrainer_6ce0b_00000: Error happened when processing _ExecutorEventType.TRAINING_RESULT.
  1. unify trial retry logic to always use re-queue.
  2. improve trial restore retry test.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

xwjiang2010 and others added 7 commits February 6, 2023 11:54
…try test.

Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com>
Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com>
Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com>
Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com>
@xwjiang2010
Copy link
Contributor Author

Copy link
Contributor

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@krfricke krfricke added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Feb 10, 2023
@xwjiang2010 xwjiang2010 removed the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Feb 10, 2023
@xwjiang2010 xwjiang2010 merged commit d9a17f2 into ray-project:master Feb 10, 2023
edoakes pushed a commit to edoakes/ray that referenced this pull request Mar 22, 2023
…e retry test. (ray-project#32242)

* [Tune] Improve logging, unify requeue logic, improve trial restore retry test.

Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com>

* fix unit test.

Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com>

* lint

Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com>

* fix test_tuner_restore

Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com>

---------

Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@xwjiang2010 xwjiang2010 deleted the improve_logging_2 branch July 26, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants