[Tune] Remove Ray Client references from Tune and Train docs/examples #32299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
…ve_ray_client_libraries
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
…ve_ray_client_libraries
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
This reverts commit a09bc3c.
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
…ve_ray_client_libraries
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
…ve_ray_client_libraries Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
justinvyu
requested review from
richardliaw,
gjoliver,
krfricke and
xwjiang2010
as code owners
justinvyu
requested review from
amogkam,
matthewdeng,
Yard1,
maxpumperla and
a team
as code owners
richardliaw
approved these changes
Feb 8, 2023
|
Are tests failures related? |
|
@richardliaw Unrelated, those are rllib tests that aren't touched by this PR. |
justinvyu
added a commit
to justinvyu/ray
that referenced
this pull request
Feb 8, 2023
…ray-project#32299) This PR removes references to Ray Client in Tune and Train examples. It also removes outdated references of needing `ray.init("auto")` being used to connect to an existing cluster vs. `ray.init()` creating a new local cluster. The latest `ray.init()` docstring explains that: > This method handles two cases; either a Ray cluster already exists and we just attach this driver to it or we start all of the processes associated with a Ray cluster and attach to the newly started cluster. New version of this PR: ray-project#31712 Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
7 tasks
matthewdeng
pushed a commit
that referenced
this pull request
Feb 10, 2023
…#32299) (#32321) This PR removes references to Ray Client in Tune and Train examples. It also removes outdated references of needing `ray.init("auto")` being used to connect to an existing cluster vs. `ray.init()` creating a new local cluster. The latest `ray.init()` docstring explains that: > This method handles two cases; either a Ray cluster already exists and we just attach this driver to it or we start all of the processes associated with a Ray cluster and attach to the newly started cluster. New version of this PR: #31712 Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
…ray-project#32299) This PR removes references to Ray Client in Tune and Train examples. It also removes outdated references of needing `ray.init("auto")` being used to connect to an existing cluster vs. `ray.init()` creating a new local cluster. The latest `ray.init()` docstring explains that: > This method handles two cases; either a Ray cluster already exists and we just attach this driver to it or we start all of the processes associated with a Ray cluster and attach to the newly started cluster. New version of this PR: ray-project#31712 Signed-off-by: Justin Yu <justinvyu@berkeley.edu> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR removes references to Ray Client in Tune and Train examples. It also removes outdated references of needing
ray.init("auto")being used to connect to an existing cluster vs.ray.init()creating a new local cluster.The latest
ray.init()docstring explains that:New version of this PR: #31712
Related issue number
Closes #31621
Closes #30227 (fixes the
pbt_ppo_example.ipynbconfig to use a valid Humanoid env, and cleans up the display output)Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.