[core] Fix comments and a corner case in #32302 #32323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scv119
reviewed
Feb 8, 2023
src/ray/rpc/grpc_server.cc
Outdated
| @@ -148,7 +149,7 @@ void GrpcServer::Run() { | |||
| if (entry->GetMaxActiveRPCs() != -1) { | |||
| buffer_size = entry->GetMaxActiveRPCs(); | |||
| } | |||
| for (int j = 0; j < (buffer_size / num_threads_); j++) { | |||
| for (int j = 0; j < std::min(1, buffer_size / num_threads_); j++) { | |||
fishbone
added
P0
scv119
approved these changes
Feb 8, 2023
cadedaniel
approved these changes
Feb 8, 2023
| @@ -40,6 +40,7 @@ GrpcServer::GrpcServer(std::string name, | |||
| is_closed_(true), | |||
| num_threads_(num_threads), | |||
| keepalive_time_ms_(keepalive_time_ms) { | |||
| RAY_CHECK(num_threads_ > 0) << "Num of threads in gRPC must be greater than 0"; | |||
There was a problem hiding this comment.
seems like a good case for an unsigned type 😄
There was a problem hiding this comment.
Yes, but potentially it still could be 0 if it's unsigned type.
fishbone
added a commit
to fishbone/ray
that referenced
this pull request
Feb 8, 2023
…ct#32323) This is a corner case where buffer could be 0 and a comments needs to be fixed in the previous PR.
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
…ct#32323) This is a corner case where buffer could be 0 and a comments needs to be fixed in the previous PR. Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This is a corner case where buffer could be 0 and a comments needs to be fixed in the previous PR.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.