[tune] Remove deprecated Resources class #32490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
February 13, 2023 12:33
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
xwjiang2010
approved these changes
Feb 16, 2023
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
The `tune.resources.Resources` class has been deprecated in favor of PlacementGroupFactory for a long time. This PR removes the old Resources class (raising an error when trying to use it) in our internal code. We keep a private copy for the resources updater for now (to use the add/subtract semantics). Signed-off-by: Kai Fricke <kai@anyscale.com> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
peytondmurray
pushed a commit
to peytondmurray/ray
that referenced
this pull request
Mar 22, 2023
The `tune.resources.Resources` class has been deprecated in favor of PlacementGroupFactory for a long time. This PR removes the old Resources class (raising an error when trying to use it) in our internal code. We keep a private copy for the resources updater for now (to use the add/subtract semantics). Signed-off-by: Kai Fricke <kai@anyscale.com>
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
The `tune.resources.Resources` class has been deprecated in favor of PlacementGroupFactory for a long time. This PR removes the old Resources class (raising an error when trying to use it) in our internal code. We keep a private copy for the resources updater for now (to use the add/subtract semantics). Signed-off-by: Kai Fricke <kai@anyscale.com> Signed-off-by: elliottower <elliot@elliottower.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kai Fricke kai@anyscale.com
Why are these changes needed?
The
tune.resources.Resourcesclass has been deprecated in favor of PlacementGroupFactory for a long time.This PR removes the old Resources class (raising an error when trying to use it) in our internal code. We keep a private copy for the resources updater for now (to use the add/subtract semantics).
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.