Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIR] Fix DatasetIterator backwards compability #32526

Merged
merged 7 commits into from
Feb 15, 2023

Conversation

bveeramani
Copy link
Member

Signed-off-by: Balaji Veeramani balaji@anyscale.com

Why are these changes needed?

TrainDatasetIterator errors if you try to access backwards compatible methods like count. This PR fixes the bug.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Copy link
Contributor

@amogkam amogkam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bveeramani and others added 3 commits February 14, 2023 17:33
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: amogkam <amogkamsetty@yahoo.com>
@amogkam amogkam mentioned this pull request Feb 15, 2023
7 tasks
@amogkam amogkam merged commit 1e401cd into ray-project:master Feb 15, 2023
edoakes pushed a commit to edoakes/ray that referenced this pull request Mar 22, 2023
TrainDatasetIterator errors if you try to access backwards compatible methods like count. This PR fixes the bug.
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: amogkam <amogkamsetty@yahoo.com>
Co-authored-by: amogkam <amogkamsetty@yahoo.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
peytondmurray pushed a commit to peytondmurray/ray that referenced this pull request Mar 22, 2023
TrainDatasetIterator errors if you try to access backwards compatible methods like count. This PR fixes the bug.
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: amogkam <amogkamsetty@yahoo.com>
Co-authored-by: amogkam <amogkamsetty@yahoo.com>
elliottower pushed a commit to elliottower/ray that referenced this pull request Apr 22, 2023
TrainDatasetIterator errors if you try to access backwards compatible methods like count. This PR fixes the bug.
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: amogkam <amogkamsetty@yahoo.com>
Co-authored-by: amogkam <amogkamsetty@yahoo.com>
Signed-off-by: elliottower <elliot@elliottower.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants