[Tune] Unrevert "Add more comprehensive support for remote_checkpoint_dir w/ url params (#32479)" #32576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r remote `upload_dir` w/ endpoint and params (ray-project#32479)" (ray-project#32571)" This reverts commit 350fb13.
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
krfricke
approved these changes
Feb 16, 2023
|
@krfricke Before merging, I want to run |
|
Ah sorry, that was a quick merge... usually it would have been Well, now it will run on master, let's see if everything works |
|
Ah ok, hopefully it is ok! |
|
Thanks folks! Will keep an eye out! |
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
…_dir w/ url params (ray-project#32479)" (ray-project#32576) This reverts the revert made here ray-project#32571. This PR fixes two suites of tests that were failing: 1. workflows tests were failing due to the pinned `moto` version being too old. 2. `test_syncer` errors were caused by reusing the same bucket name between tests. This PR also fixes the `restore` path for URIs with params, which was missing from the previous PR. The e2e sync test has been updated to also test restoration. Signed-off-by: Justin Yu <justinvyu@berkeley.edu> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
peytondmurray
pushed a commit
to peytondmurray/ray
that referenced
this pull request
Mar 22, 2023
…_dir w/ url params (ray-project#32479)" (ray-project#32576) This reverts the revert made here ray-project#32571. This PR fixes two suites of tests that were failing: 1. workflows tests were failing due to the pinned `moto` version being too old. 2. `test_syncer` errors were caused by reusing the same bucket name between tests. This PR also fixes the `restore` path for URIs with params, which was missing from the previous PR. The e2e sync test has been updated to also test restoration. Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
…_dir w/ url params (ray-project#32479)" (ray-project#32576) This reverts the revert made here ray-project#32571. This PR fixes two suites of tests that were failing: 1. workflows tests were failing due to the pinned `moto` version being too old. 2. `test_syncer` errors were caused by reusing the same bucket name between tests. This PR also fixes the `restore` path for URIs with params, which was missing from the previous PR. The e2e sync test has been updated to also test restoration. Signed-off-by: Justin Yu <justinvyu@berkeley.edu> Signed-off-by: elliottower <elliot@elliottower.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This reverts the revert made here #32571.
This PR fixes two suites of tests that were failing:
motoversion being too old.test_syncererrors were caused by reusing the same bucket name between tests.This PR also fixes the
restorepath for URIs with params, which was missing from the previous PR. The e2e sync test has been updated to also test restoration.See changes from new commits only here: new commits
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.